From: Jani Nikula <jani@nikula.org>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH WIP v3 0/3] emacs: show: change the unread handling
Date: Mon, 09 Dec 2013 10:46:18 +0100 [thread overview]
Message-ID: <871u1ms6fp.fsf@nikula.org> (raw)
In-Reply-To: <1386273871-24214-1-git-send-email-markwalters1009@gmail.com>
On Thu, 05 Dec 2013, Mark Walters <markwalters1009@gmail.com> wrote:
> This is the next iteration of this WIP patch series. v2 was at
> id:1385892147-16994-1-git-send-email-markwalters1009@gmail.com
>
> I would just like to emphasise that *all* feedback is appreciated
> including "I HATE IT" etc.
I LIKE IT. :)
It's not perfect, but IMHO it's a nice, incremental improvement over
what we have, and it's discoverable: you can see what it does and
when. If anything is surprising, the user has a better chance of
explaining what happened, and what he liked and didn't.
Good work, Mark!
BR,
Jani.
PS. I didn't look at the code, I only tried it.
> I have followed Jani's suggestion and removed the delayed updates to
> unread status: it makes it harder to see if the heuristics are doing
> what you want.
>
> The first patch is completely new: it makes all tag changes in a
> buffer (in particular the unread tag) clearly visible to the user: a
> deleted tag is displayed with red strike-through and an added tag is
> displayed underlined in green. (This may have strange interactions with
> notmuch-tag-formats in some cases.)
>
> This makes the visual feedback when a message is marked unread very
> clear: the unread tag is struck-through.
>
> As always with the previous series lots of tests will fail for the
> obvious reason that marking read is done differently and displayed
> differently.
>
> Best wishes
>
> Mark
>
>
>
>
> Mark Walters (3):
> emacs: show: mark tags changed since buffer loaded
> emacs: show: add an update seen function to post-command-hook
> emacs: show: make `seen' mean user viewed whole message
>
> emacs/notmuch-show.el | 136 +++++++++++++++++++++++++++++++++++++++++-------
> emacs/notmuch-tag.el | 30 +++++++----
> 2 files changed, 136 insertions(+), 30 deletions(-)
>
> --
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
prev parent reply other threads:[~2013-12-09 9:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 20:04 [PATCH WIP v3 0/3] emacs: show: change the unread handling Mark Walters
2013-12-05 20:04 ` [PATCH WIP v3 1/3] emacs: show: mark tags changed since buffer loaded Mark Walters
2013-12-09 8:44 ` Jani Nikula
2013-12-05 20:04 ` [PATCH WIP v3 2/3] emacs: show: add an update seen function to post-command-hook Mark Walters
2013-12-05 20:04 ` [PATCH WIP v3 3/3] emacs: show: make `seen' mean user viewed whole message Mark Walters
2013-12-09 9:46 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871u1ms6fp.fsf@nikula.org \
--to=jani@nikula.org \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).