From: David Bremner <david@tethera.net>
To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 01/10] lib: add return status to database close and destroy
Date: Sat, 05 Jul 2014 09:39:43 -0300 [thread overview]
Message-ID: <871tu0rncg.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <1397653165-15620-2-git-send-email-novalazy@gmail.com>
Peter Wang <novalazy@gmail.com> writes:
> From: Jani Nikula <jani@nikula.org>
>
> notmuch_database_close may fail in Xapian ->flush() or ->close(), so
> report the status. Similarly for notmuch_database_destroy which calls
> close.
This patch looks OK, and it makes sense independent of what else
follows with respect to notmuch-insert.
With respect so SONAME bumping, we might be able to get away with out it
here (although that could be un-portable or broken in a way I haven't
seen yet), but we can also delay that decision until closer to the next
release; I don't think it's as important to provide a stable ABI for
people building from git, and I'd prefer to batch ABI changes into one
SONAME bump.
next prev parent reply other threads:[~2014-07-05 12:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 12:59 [PATCH v2 00/10] add insert --must-index option Peter Wang
2014-04-16 12:59 ` [PATCH v2 01/10] lib: add return status to database close and destroy Peter Wang
2014-07-05 12:39 ` David Bremner [this message]
2014-07-09 23:41 ` David Bremner
2014-04-16 12:59 ` [PATCH v2 02/10] lib: bump soname Peter Wang
2014-04-16 12:59 ` [PATCH v2 03/10] python: handle return status of database close and destroy Peter Wang
2014-07-05 12:43 ` David Bremner
2014-04-16 12:59 ` [PATCH v2 04/10] go: add return status to database close method Peter Wang
2014-04-16 12:59 ` [PATCH v2 05/10] ruby: handle return status of database close Peter Wang
2014-07-05 12:55 ` David Bremner
2014-04-16 12:59 ` [PATCH v2 06/10] cli: refactor insert Peter Wang
2014-07-05 13:18 ` David Bremner
2014-07-06 3:57 ` Peter Wang
2014-07-08 23:24 ` David Bremner
2014-09-16 19:32 ` David Bremner
2014-04-16 12:59 ` [PATCH v2 07/10] cli: indicate insert failure mode in exit status Peter Wang
2014-04-16 12:59 ` [PATCH v2 08/10] cli: add insert --must-index option Peter Wang
2014-07-09 23:20 ` David Bremner
2014-07-28 14:48 ` Peter Wang
2014-04-16 12:59 ` [PATCH v2 09/10] test: test insert --must-index Peter Wang
2014-04-16 12:59 ` [PATCH v2 10/10] man: update insert documentation Peter Wang
2014-05-06 21:00 ` [PATCH v2 00/10] add insert --must-index option Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tu0rncg.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=novalazy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).