Re: [PATCH v3] nmbug: Translate to Python

[David Bremner <bremner@debian.org>]

"W. Trevor King" <wking@tremily.us> writes:
>
>> > +__version__ = '0.2'
>> 
>> Do we need/want a version distinct from that of notmuch?
>
> nmbug is very loosely bound to the notmuch core.  To me it feels like
> a separate project that happens to share the same version control
> repository.  I'm happy to synchronize versions, but then we have to
> remember to bump the nmbug version for each notmuch release.

Unless/until we split nmbug from notmuch I'd rather keep the versions
the same to avoid confusion.  I guess the "right way" (TM) would be
share the hackery used in doc/conf.py to parse the version file and use
it from python.

>> as a non-native speaker of python, I find this a bit hard to read.
>> How about adding some parens to make the multiple return more clear,
>> so
>> 
>>     (status, tree, stderr) = _git(
>
> That's legal, but I rarely see the parenthesized version in the wild.
> For examples showing the unparenthesized version, see [2,3].
> Parentheses are optional for Python tuples [4], so you'd only want
> them if ‘=’ had a higher precedence than ‘,’.  That's my argument for
> the unparenthesized version, but feel free to overrule me ;).

I'd rather go with readability (which I admit is subjective) then try to
minimize parens. We're lisp programmers, after all ;).