From: David Bremner <david@tethera.net>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 1/3] search: Separately report matching and non-matching authors.
Date: Sun, 18 Jan 2015 15:19:23 +0100 [thread overview]
Message-ID: <871tms9no4.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <1414172643-28270-2-git-send-email-dme@dme.org>
David Edmondson <dme@dme.org> writes:
> In addition to the 'authors' attribute of each search result, include
> 'authors_matched' and 'authors_non_matched' attributes. Both
> attributes are always included and are formatted as a list of
> authors. If there are no matching authors, the 'authors_non_matched'
> attribute is set to the empty list.
> ---
It would be nicer if the tests were repaired in the same commit, or
minimally marked broken.
> static int
> do_search_threads (sprinter_t *format,
> notmuch_query_t *query,
> @@ -152,6 +253,10 @@ do_search_threads (sprinter_t *format,
> format->integer (format, total);
> format->map_key (format, "authors");
> format->string (format, authors);
> + if (_enumerate_authors (format, thread) < 0) {
> + fprintf (stderr, "Out of memory\n");
> + return 1;
> + }
Maybe I'm just blind, but I don't see how enumerate authors ever returns
anything other than 0.
next prev parent reply other threads:[~2015-01-18 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 17:44 [PATCH v2 0/3] Improve the display of matching/non-matching authors David Edmondson
2014-10-24 17:44 ` [PATCH v2 1/3] search: Separately report matching and non-matching authors David Edmondson
2015-01-18 14:19 ` David Bremner [this message]
2015-01-18 17:59 ` Mark Walters
2015-01-19 9:14 ` David Edmondson
2014-10-24 17:44 ` [PATCH v2 2/3] emacs: Improved display of matching/non-matching authors David Edmondson
2015-01-18 14:27 ` David Bremner
2015-01-18 18:10 ` Mark Walters
2015-01-19 9:18 ` David Edmondson
2014-10-24 17:44 ` [PATCH v2 3/3] test: Update tests for 'authors_matched' and authors_non_matched' David Edmondson
2015-01-18 18:12 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tms9no4.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).