From: David Bremner <david@tethera.net>
To: Johannes Schauer <josch@debian.org>, notmuch@notmuchmail.org
Subject: Re: [bug] notmuch requires Content-Disposition mime header value to be lower case
Date: Fri, 18 Sep 2015 10:26:00 -0300 [thread overview]
Message-ID: <871tdvvoyf.fsf@tesseract.cs.unb.ca> (raw)
In-Reply-To: <20150918123724.1941.3900@localhost>
Johannes Schauer <josch@debian.org> writes:
> Hi,
>
> Quoting David Bremner (2015-09-18 14:03:20)
>> I'd recommend making your own new test, rather than modifying existing
>> ones to test multiple things. I'd also recommend using json / sexp
>> output for your tests, since the ad-hoc text format is kindof
>> semi-deprecated.
>
> can you take care of that? My goal was actually just to report this bug, not to
> spend more time to develop a proper patch for it :)
Consider the bug reported. At the moment I'm not completely convinced
the patch is correct, never mind the tests. I agree it looks obvious
enough, but the test results don't make sense to me yet.
>
> Also, a related problem occurs when the Content-Disposition header contains
> UTF8 characters, in which case the header value gets encoded. Apparently
> notmuch does not attempt to decode it. Example mime header:
>
> --===============7161366892858136962==
> Content-Type: application/pdf
> MIME-Version: 1.0
> Content-Transfer-Encoding: base64
> Content-Disposition: =?utf-8?b?YXR0YWNobWVudDsgZmlsZW5hbWU9ImJlZ3LDvMOfdW5n?=
> =?utf-8?b?LnBkZiI=?=
yes, that sounds like a distinct bug.
next prev parent reply other threads:[~2015-09-18 13:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150917070056.1941.94846@localhost>
[not found] ` <20150917083612.1941.22480@localhost>
2015-09-17 8:39 ` [bug] notmuch requires Content-Disposition mime header value to be lower case Johannes Schauer
2015-09-18 12:03 ` David Bremner
2015-09-18 12:37 ` Johannes Schauer
2015-09-18 13:26 ` David Bremner [this message]
2015-09-26 8:59 ` Jani Nikula
2015-09-26 9:35 ` [PATCH 1/2] lib: content disposition values are not case-sensitive Jani Nikula
2015-09-26 9:35 ` [PATCH 2/2] cli: " Jani Nikula
2015-10-06 10:20 ` [WIP] tests: add test for case insensitive Content-Disposition David Bremner
2015-10-18 11:58 ` Jani Nikula
2015-10-18 12:05 ` Johannes Schauer
2015-11-19 11:57 ` [PATCH 1/2] lib: content disposition values are not case-sensitive David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tdvvoyf.fsf@tesseract.cs.unb.ca \
--to=david@tethera.net \
--cc=josch@debian.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).