From: Carl Worth <cworth@cworth.org>
To: Tomi Ollila <tomi.ollila@iki.fi>,
David Bremner <david@tethera.net>,
notmuch@notmuchmail.org
Subject: Re: elisp + company completion patches, v7
Date: Mon, 26 Oct 2015 11:56:56 -0700 [thread overview]
Message-ID: <871tche9vr.fsf@wondoo.home.cworth.org> (raw)
In-Reply-To: <m2lhaqu23j.fsf@guru.guru-group.fi>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Sun, Oct 25 2015, Tomi Ollila wrote:
> I, if this does not sound nitpicking, would amend those 'This patch' and
> 'With this patch' texts in commit messages away by some rewording -- those
> pose as a bad example for someone reading the code -- and diminish the
> effect when I complain that again in future patched ;)
What's the motivation here?
It's often the case that a good commit message needs to describe the way
things were working prior to a commit, (describing the bug or missing
feature or what have you), and also needs to describe the change that is
affected by the commit itself.
So I actually like seeing commit messages that say things like:
Prior to this commit... (some bug existed...)
In this commit... (some code is reworked to fix the bug...)
But maybe I've missed the point of your message.
-Carl
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2015-10-26 18:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-25 15:23 elisp + company completion patches, v7 David Bremner
2015-10-25 15:23 ` [Patch v7 1/3] emacs: replace use of notmuch-address-message-insinuate David Bremner
2015-10-25 15:23 ` [Patch v7 2/3] Emacs: Add address completion mechanism implemented in elisp David Bremner
2015-10-25 17:28 ` Mark Walters
2015-10-25 15:23 ` [Patch v7 3/3] Emacs: Add address completion based on company-mode David Bremner
2015-10-25 17:26 ` Mark Walters
2015-10-25 20:26 ` elisp + company completion patches, v7 Tomi Ollila
2015-10-26 18:56 ` Carl Worth [this message]
2015-10-27 22:55 ` Tomi Ollila
2015-10-25 21:40 ` Aaron Ecay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tche9vr.fsf@wondoo.home.cworth.org \
--to=cworth@cworth.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).