From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 47BFC6DE00DD for ; Fri, 11 Dec 2015 06:03:13 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.312 X-Spam-Level: X-Spam-Status: No, score=-0.312 tagged_above=-999 required=5 tests=[AWL=0.239, RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zKIOWxZ_NxPb for ; Fri, 11 Dec 2015 06:03:07 -0800 (PST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id ACF026DE005F for ; Fri, 11 Dec 2015 06:03:07 -0800 (PST) Received: from remotemail by fethera.tethera.net with local (Exim 4.84) (envelope-from ) id 1a7OHn-0000Z3-Gt; Fri, 11 Dec 2015 09:03:03 -0500 Received: (nullmailer pid 15924 invoked by uid 1000); Fri, 11 Dec 2015 14:03:05 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH 2/9] Add a lazily-initialized crypto context to notmuch_database_t In-Reply-To: <1449718786-28000-3-git-send-email-dkg@fifthhorseman.net> References: <1449718786-28000-1-git-send-email-dkg@fifthhorseman.net> <1449718786-28000-3-git-send-email-dkg@fifthhorseman.net> User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 11 Dec 2015 10:03:05 -0400 Message-ID: <871tatf5gm.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Dec 2015 14:03:13 -0000 Daniel Kahn Gillmor writes: > This is in large part a duplicate of parts of crypto.c, but that code > is in the client (outside the library), and we don't want to entangle > the libgmime API with the libnotmuch API. > > I welcome better proposals for how to share this code explicitly > between the library and the client. Maybe I miss something obvious, but util/libutil.a is exactly there for sharing code between the library and the client. perhaps something like "gmime-extra.c" to go with {talloc,zlib}-extra.c I didn't look at the code yet, just the commentary. d