From: David Bremner <david@tethera.net>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v4 11/16] add --try-decrypt to notmuch insert
Date: Sun, 14 Aug 2016 09:16:54 +0900 [thread overview]
Message-ID: <871t1s5hmx.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <1467970047-8013-12-git-send-email-dkg@fifthhorseman.net>
Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
> + status = notmuch_indexopts_set_try_decrypt (indexopts, try_decrypt);
> + if (status != NOTMUCH_STATUS_SUCCESS) {
> + fprintf (stderr, "Error: Failed to set try_decrypt to %s. (%s)\n",
> + try_decrypt ? "True" : "False", notmuch_status_to_string (status));
> + notmuch_indexopts_destroy (indexopts);
> + return EXIT_FAILURE;
> + }
This patch looks fine. I wondered whether it might be useful to add a
"print_status_indexopts" function to status.c to reduce some of the
boilerplate. I think the current way is only a bit longer, so probably
not worth the extra obfuscation, but feel free to add such a function if
you like; it's mainly interesting if there is potential secondary info
from notmuch_database_status_string.
d
next prev parent reply other threads:[~2016-08-14 0:19 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 9:27 Allow indexing cleartext of encrypted messages (v4) Daniel Kahn Gillmor
2016-07-08 9:27 ` [PATCH v4 01/16] add util/search-path.{c, h} to test for executables in $PATH Daniel Kahn Gillmor
2016-08-12 5:51 ` David Bremner
2016-08-12 6:19 ` Daniel Kahn Gillmor
2016-08-12 7:38 ` David Bremner
2016-08-12 18:46 ` Daniel Kahn Gillmor
2016-08-12 20:01 ` Tomi Ollila
2016-08-12 23:03 ` David Bremner
2016-07-08 9:27 ` [PATCH v4 02/16] Move crypto.c into libutil Daniel Kahn Gillmor
2016-08-07 13:32 ` David Bremner
2016-08-12 6:17 ` David Bremner
2016-08-13 8:01 ` Tomi Ollila
2016-08-13 8:27 ` David Bremner
2016-07-08 9:27 ` [PATCH v4 03/16] make shared crypto code behave library-like Daniel Kahn Gillmor
2016-08-12 7:46 ` David Bremner
2016-07-08 9:27 ` [PATCH v4 04/16] Provide _notmuch_crypto_{set,get}_gpg_path Daniel Kahn Gillmor
2016-08-12 8:04 ` David Bremner
2016-07-08 9:27 ` [PATCH v4 05/16] Choose the default gpg_path with _notmuch_crypto_get_gpg_path (NULL) Daniel Kahn Gillmor
2016-07-08 9:27 ` [PATCH v4 06/16] Prefer gpg2 in the test suite if available Daniel Kahn Gillmor
2016-08-12 8:19 ` David Bremner
2016-07-08 9:27 ` [PATCH v4 07/16] create a notmuch_indexopts_t index options object Daniel Kahn Gillmor
2016-07-08 9:27 ` [PATCH v4 08/16] reorganize indexing of multipart/signed and multipart/encrypted Daniel Kahn Gillmor
2016-08-13 4:30 ` David Bremner
2016-07-08 9:27 ` [PATCH v4 09/16] index encrypted parts when asked Daniel Kahn Gillmor
2016-07-14 13:59 ` David Bremner
2016-07-14 16:22 ` Daniel Kahn Gillmor
2016-07-15 0:23 ` David Bremner
2016-07-15 7:46 ` Daniel Kahn Gillmor
2016-08-13 13:23 ` David Bremner
2016-07-08 9:27 ` [PATCH v4 10/16] Add n_d_add_message_with_indexopts (extension of n_d_add_message) Daniel Kahn Gillmor
2016-08-14 0:08 ` David Bremner
2016-07-08 9:27 ` [PATCH v4 11/16] add --try-decrypt to notmuch insert Daniel Kahn Gillmor
2016-08-14 0:16 ` David Bremner [this message]
2016-07-08 9:27 ` [PATCH v4 12/16] add --try-decrypt to notmuch new Daniel Kahn Gillmor
2016-08-14 0:22 ` David Bremner
2016-07-08 9:27 ` [PATCH v4 13/16] add indexopts to notmuch python bindings Daniel Kahn Gillmor
2016-08-14 0:41 ` David Bremner
2016-07-08 9:27 ` [PATCH v4 14/16] test indexing cleartext version of delivered messages Daniel Kahn Gillmor
2016-08-14 1:14 ` David Bremner
2016-07-08 9:27 ` [PATCH v4 15/16] added notmuch_message_reindex Daniel Kahn Gillmor
2016-08-14 12:43 ` [PATCH] WIP: remove all non-prefixed-terms (and stemmed versions) David Bremner
2017-04-02 14:52 ` David Bremner
2016-07-08 9:27 ` [PATCH v4 16/16] add "notmuch reindex" subcommand Daniel Kahn Gillmor
2016-08-14 22:42 ` David Bremner
2016-08-14 23:41 ` Olly Betts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871t1s5hmx.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).