unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: laochailan <laochailan@web.de>, notmuch@notmuchmail.org
Cc: laochailan <laochailan@web.de>
Subject: Re: [PATCH 0/5] Additions to Go bindings
Date: Sun, 04 Sep 2016 08:07:11 -0300	[thread overview]
Message-ID: <871t0zkjog.fsf@zancas.localnet> (raw)
In-Reply-To: <1433073735-7721-1-git-send-email-laochailan@web.de>

laochailan <laochailan@web.de> writes:

> I added bindings for thread lists and thread to the Go bindings and fixed
> some wrong constant values.
>
> Before, the comment style was not understood well by the automatic
> documentation generator of Go, so I converted the documentation comments
> to the // style.
>
> Compare the documentation before:
> http://godoc.org/github.com/notmuch/notmuch/bindings/go/src/notmuch#Message.RemoveTag
> and after the changes:
> http://godoc.org/github.com/laochailan/notmuch/bindings/go/src/notmuch#Message.RemoveTag
>
> laochailan (5):
>   Added thread bindings to go bindings
>   fixed wrong constant values
>   formatted comments for better godoc output
>   fixed more wrongly initialized constants
>   updated NEWS

I have pushed patches 1, 2, and a modified version of 5.

d

      parent reply	other threads:[~2016-09-04 11:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-31 12:02 [PATCH 0/5] Additions to Go bindings laochailan
2015-05-31 12:02 ` [PATCH 1/5] Added thread bindings to go bindings laochailan
2015-05-31 12:02 ` [PATCH 2/5] fixed wrong constant values laochailan
2015-05-31 12:02 ` [PATCH 3/5] formatted comments for better godoc output laochailan
2015-05-31 12:02 ` [PATCH 4/5] fixed more wrongly initialized constants laochailan
2015-05-31 12:02 ` [PATCH 5/5] updated NEWS laochailan
2016-09-03 23:26 ` [PATCH 0/5] Additions to Go bindings David Bremner
2016-09-04 11:07 ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871t0zkjog.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=laochailan@web.de \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).