From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id A80666DE01F7 for ; Mon, 12 Sep 2016 20:15:55 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FIiXRsN2w2d6 for ; Mon, 12 Sep 2016 20:15:55 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTP id E08186DE00BD for ; Mon, 12 Sep 2016 20:15:54 -0700 (PDT) Received: from fifthhorseman.net (unknown [31.131.247.74]) by che.mayfirst.org (Postfix) with ESMTPSA id 27BE9F98C; Mon, 12 Sep 2016 23:15:51 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 9A2B220457; Tue, 13 Sep 2016 01:30:11 +0200 (CEST) From: Daniel Kahn Gillmor To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH v2] emacs: reply: remove wrong sig/enc status buttons In-Reply-To: <1473718339-19946-1-git-send-email-markwalters1009@gmail.com> References: <877fahq5v3.fsf@zancas.localnet> <1473718339-19946-1-git-send-email-markwalters1009@gmail.com> Date: Tue, 13 Sep 2016 01:30:06 +0200 Message-ID: <871t0obssh.fsf@alice.fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2016 03:15:55 -0000 --=-=-= Content-Type: text/plain Hi Mark-- On Tue 2016-09-13 00:12:19 +0200, Mark Walters wrote: > This stopps the (usually incorrect) sigstatus and encstatus buttons > appearing when replying in emacs, and updates the test suite to match. > > Overriding the status button functions is a little unusual but much > less intrusive than passing an argument all the way down the call > chain. It also makes it clear exactly what it does. > > We also hide the application/pgp-encrypted part as it can only contain > "Version: 1". We do this in notmuch show, which means it also happens > when replying. > > --- > > This fixes the bug David mentioned of Version: 1 appearing in the > reply. We actually fix it by making notmuch-show.el not display this > either. hm, fwiw, i am still seeing Version: 1 in both the replies and in the plaintext message body, even with this patch applied :/ not sure what i should do to give you more debugging info. any pointers? --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJX1zp+XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFREIyRTc0RjU2RkNGMkI2NzI5N0I3MzUy NEVDRkY1QUZGNjgzNzBBAAoJECTs/1r/aDcKtu0P/1o1nxXT44ayJ8NBVRi/fFrZ VzREkxMT7jDcE/X/6mPRWzZfvYL78aihk9VJ4Z64DX6kaR/RmzAqpAiVtg5OuPZD QgjXoR+/e/wtNj+YYpkq5xgyquKJ7qLy7BK0SFfAT1WMBmsBNwRCIBIYZ80LcuKY tZ8qkVJ9ox+p6guginT8GgBo1XdY18zpCWFGhUVA8teZna2mrSk6NPRNcnpgXwpl 6kS1w7bp83WfzgF3OgTiOn6nTjNQ39MWOLrp9GpJpaWkzenAT6630Pevm7D2WTt6 yFfc12F45tQqxwsBtYUYzlYxmZCTTDNTcCV39l+mBbmOSOHr5VqHXLErmO2KaQkM UXXUxVSBaqaSma/rzo8sJ+GVgyFsApekmAyiQ33wOH3GxieiPdNV0ELRfipqCuG3 6h9BX5lPnTkLExo6KEBtczcIIOPb2gQKAwK7BEwDFOcGY2/6vzX6oaYtBAHmvsbp jZJMCnGacRPLpUyHOYPm6LaUQ5FpXNfrEJhVTaJ+U2tivFrxs409GBT88flTM7y9 Q+O19JdJsIX2GIT9puCPMKTj57HIspjqEU/tCIRNiD1f4YAC9UOy2qW9QQXJWyfP cOUBOcyO8vjNR0KobcskwMt1F6v2jZcMBGsEH8vtuJ8hXh0vKURHn3olALIeuSUq seldsqURCdFrcvrUmVHs =G7Bf -----END PGP SIGNATURE----- --=-=-=--