From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id B5F5C6DE1381 for ; Tue, 11 Oct 2016 04:25:43 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.006 X-Spam-Level: X-Spam-Status: No, score=-0.006 tagged_above=-999 required=5 tests=[AWL=0.005, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ipALMDVEXHdg for ; Tue, 11 Oct 2016 04:25:42 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id ED78A6DE137A for ; Tue, 11 Oct 2016 04:25:41 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1btvBT-0003Kw-0C; Tue, 11 Oct 2016 07:25:23 -0400 Received: (nullmailer pid 17129 invoked by uid 1000); Tue, 11 Oct 2016 11:25:35 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs/show: force notmuch-show-buttonise-links to act on lines In-Reply-To: References: <87fuo5wmlk.fsf@zancas.localnet> <20161009223044.31442-1-david@tethera.net> Date: Tue, 11 Oct 2016 08:25:35 -0300 Message-ID: <871sznw2j4.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 11:25:43 -0000 Tomi Ollila writes: > On Mon, Oct 10 2016, David Bremner wrote: > >> This seems to fix a problem with emacs 25 creating partial buttons by >> calling n-s-b-l with a region that does not include the whole button. >> I'm not 100% sure it's legit to act outside the region passed by >> jit-lock, but goto-address-fontify-region (where I borrowed the code >> from) already does this, so this patch to not make things worse. >> --- > > Applies cleanly and fixes the test in question on fedora 24 I was a bit worried about the performance impact, but according to profiling it doesn't really seem to be a hotspot, 0% in profiling of rending a 600 message thread. So unless I hear some cogent objections, I'm going ahead with this. d