From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs/show: force notmuch-show-buttonise-links to act on lines
Date: Tue, 11 Oct 2016 08:25:35 -0300 [thread overview]
Message-ID: <871sznw2j4.fsf@zancas.localnet> (raw)
In-Reply-To: <m2y41wjbuq.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> On Mon, Oct 10 2016, David Bremner <david@tethera.net> wrote:
>
>> This seems to fix a problem with emacs 25 creating partial buttons by
>> calling n-s-b-l with a region that does not include the whole button.
>> I'm not 100% sure it's legit to act outside the region passed by
>> jit-lock, but goto-address-fontify-region (where I borrowed the code
>> from) already does this, so this patch to not make things worse.
>> ---
>
> Applies cleanly and fixes the test in question on fedora 24
I was a bit worried about the performance impact, but according to
profiling it doesn't really seem to be a hotspot, 0% in profiling of
rending a 600 message thread. So unless I hear some cogent objections,
I'm going ahead with this.
d
next prev parent reply other threads:[~2016-10-11 11:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 2:44 "id buttonization" test failure Marius Bakke
2016-10-06 13:08 ` David Bremner
2016-10-08 1:30 ` David Bremner
2016-10-08 12:33 ` David Bremner
2016-10-09 15:47 ` David Bremner
2016-10-09 22:30 ` [PATCH] emacs/show: force notmuch-show-buttonise-links to act on lines David Bremner
2016-10-10 18:30 ` Tomi Ollila
2016-10-11 11:25 ` David Bremner [this message]
2016-10-12 1:49 ` David Bremner
2016-10-12 2:05 ` "id buttonization" test failure David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sznw2j4.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).