* [PATCH] emacs: interesting-buffer bugfixes/updates
@ 2016-10-22 12:10 Mark Walters
2016-10-22 15:11 ` Tomi Ollila
2016-10-26 1:03 ` David Bremner
0 siblings, 2 replies; 4+ messages in thread
From: Mark Walters @ 2016-10-22 12:10 UTC (permalink / raw)
To: notmuch
The command notmuch-interesting-buffer has got out of date -- it
doesn't mention notmuch-tree, and it still refers to message-mode not
notmuch-message-mode. Update both of these.
This fixes the bug that notmuch-cycle-notmuch-buffers does not include
notmuch-tree or notmuch-message-mode buffers in its cycling.
---
Jani pointed notmuch-cycle-notmuch-buffers out to me on irc (I hadn't
known it existed). It seems like it could be very useful.
However, it call notmuch-interesting-buffer which has not been updated
since 2011, so doesn't know about notmuch-tree or
notmuch-message-mode. notmuch-tree came into mainline in 2013, and we
switched to notmuch-message-mode (from message-mode) in August last
year, so both bugs have been present for quite some time.
Best wishes
Mark
emacs/notmuch.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index bd08aa0..2fc72b7 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -1066,8 +1066,9 @@ current search results AND that are tagged with the given tag."
(with-current-buffer b
(memq major-mode '(notmuch-show-mode
notmuch-search-mode
+ notmuch-tree-mode
notmuch-hello-mode
- message-mode))))
+ notmuch-message-mode))))
;;;###autoload
(defun notmuch-cycle-notmuch-buffers ()
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] emacs: interesting-buffer bugfixes/updates
2016-10-22 12:10 [PATCH] emacs: interesting-buffer bugfixes/updates Mark Walters
@ 2016-10-22 15:11 ` Tomi Ollila
2016-10-23 18:53 ` Jani Nikula
2016-10-26 1:03 ` David Bremner
1 sibling, 1 reply; 4+ messages in thread
From: Tomi Ollila @ 2016-10-22 15:11 UTC (permalink / raw)
To: Mark Walters, notmuch
On Sat, Oct 22 2016, Mark Walters <markwalters1009@gmail.com> wrote:
> The command notmuch-interesting-buffer has got out of date -- it
> doesn't mention notmuch-tree, and it still refers to message-mode not
> notmuch-message-mode. Update both of these.
>
> This fixes the bug that notmuch-cycle-notmuch-buffers does not include
> notmuch-tree or notmuch-message-mode buffers in its cycling.
Looks pretty obvious to me. +1
>
> ---
>
> Jani pointed notmuch-cycle-notmuch-buffers out to me on irc (I hadn't
> known it existed). It seems like it could be very useful.
>
> However, it call notmuch-interesting-buffer which has not been updated
> since 2011, so doesn't know about notmuch-tree or
> notmuch-message-mode. notmuch-tree came into mainline in 2013, and we
> switched to notmuch-message-mode (from message-mode) in August last
> year, so both bugs have been present for quite some time.
>
> Best wishes
>
> Mark
>
>
>
>
>
>
> emacs/notmuch.el | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index bd08aa0..2fc72b7 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -1066,8 +1066,9 @@ current search results AND that are tagged with the given tag."
> (with-current-buffer b
> (memq major-mode '(notmuch-show-mode
> notmuch-search-mode
> + notmuch-tree-mode
> notmuch-hello-mode
> - message-mode))))
> + notmuch-message-mode))))
>
> ;;;###autoload
> (defun notmuch-cycle-notmuch-buffers ()
> --
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] emacs: interesting-buffer bugfixes/updates
2016-10-22 15:11 ` Tomi Ollila
@ 2016-10-23 18:53 ` Jani Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2016-10-23 18:53 UTC (permalink / raw)
To: Tomi Ollila, Mark Walters, notmuch
On Sat, 22 Oct 2016, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Sat, Oct 22 2016, Mark Walters <markwalters1009@gmail.com> wrote:
>
>> The command notmuch-interesting-buffer has got out of date -- it
>> doesn't mention notmuch-tree, and it still refers to message-mode not
>> notmuch-message-mode. Update both of these.
>>
>> This fixes the bug that notmuch-cycle-notmuch-buffers does not include
>> notmuch-tree or notmuch-message-mode buffers in its cycling.
>
> Looks pretty obvious to me. +1
And works for me.
Thanks for fixing this.
BR,
Jani.
>
>>
>> ---
>>
>> Jani pointed notmuch-cycle-notmuch-buffers out to me on irc (I hadn't
>> known it existed). It seems like it could be very useful.
>>
>> However, it call notmuch-interesting-buffer which has not been updated
>> since 2011, so doesn't know about notmuch-tree or
>> notmuch-message-mode. notmuch-tree came into mainline in 2013, and we
>> switched to notmuch-message-mode (from message-mode) in August last
>> year, so both bugs have been present for quite some time.
>>
>> Best wishes
>>
>> Mark
>>
>>
>>
>>
>>
>>
>> emacs/notmuch.el | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
>> index bd08aa0..2fc72b7 100644
>> --- a/emacs/notmuch.el
>> +++ b/emacs/notmuch.el
>> @@ -1066,8 +1066,9 @@ current search results AND that are tagged with the given tag."
>> (with-current-buffer b
>> (memq major-mode '(notmuch-show-mode
>> notmuch-search-mode
>> + notmuch-tree-mode
>> notmuch-hello-mode
>> - message-mode))))
>> + notmuch-message-mode))))
>>
>> ;;;###autoload
>> (defun notmuch-cycle-notmuch-buffers ()
>> --
>> 2.1.4
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> https://notmuchmail.org/mailman/listinfo/notmuch
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] emacs: interesting-buffer bugfixes/updates
2016-10-22 12:10 [PATCH] emacs: interesting-buffer bugfixes/updates Mark Walters
2016-10-22 15:11 ` Tomi Ollila
@ 2016-10-26 1:03 ` David Bremner
1 sibling, 0 replies; 4+ messages in thread
From: David Bremner @ 2016-10-26 1:03 UTC (permalink / raw)
To: Mark Walters, notmuch
Mark Walters <markwalters1009@gmail.com> writes:
> The command notmuch-interesting-buffer has got out of date -- it
> doesn't mention notmuch-tree, and it still refers to message-mode not
> notmuch-message-mode. Update both of these.
>
pushed to release and master.
d
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-26 1:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-22 12:10 [PATCH] emacs: interesting-buffer bugfixes/updates Mark Walters
2016-10-22 15:11 ` Tomi Ollila
2016-10-23 18:53 ` Jani Nikula
2016-10-26 1:03 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).