From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 005226DE1923 for ; Sat, 11 Mar 2017 06:08:31 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.005 X-Spam-Level: X-Spam-Status: No, score=-0.005 tagged_above=-999 required=5 tests=[AWL=0.006, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3eVQRdraw1s2 for ; Sat, 11 Mar 2017 06:08:30 -0800 (PST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 6FD8E6DE1918 for ; Sat, 11 Mar 2017 06:08:30 -0800 (PST) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1cmhgS-00040i-Gi; Sat, 11 Mar 2017 09:07:48 -0500 Received: (nullmailer pid 26456 invoked by uid 1000); Sat, 11 Mar 2017 14:08:28 -0000 From: David Bremner To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: remove use of message-send-hook In-Reply-To: <1479416079-6319-1-git-send-email-markwalters1009@gmail.com> References: <1479416079-6319-1-git-send-email-markwalters1009@gmail.com> Date: Sat, 11 Mar 2017 10:08:28 -0400 Message-ID: <871su3sy77.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2017 14:08:31 -0000 Mark Walters writes: > We use message-send-hook for two things -- tagging drafts deleted, and > tagging replied the parent message of a reply. We should not use > message-send-hook as that will affect gnus etc too. Moreover, > message-send-hook is run before the message is sent, even before the > user confirms they want to send it (if message-confirm-send is > set). This means the user can do C-c C-c to send, then cancel, and the > parent is still tagged replied. pushed to master d