From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 9DE6C6DE1203
 for <notmuch@notmuchmail.org>; Sun, 20 Aug 2017 06:43:51 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.011,
 SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id x4CqzbwAZRir for <notmuch@notmuchmail.org>;
 Sun, 20 Aug 2017 06:43:50 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 723896DE111A
 for <notmuch@notmuchmail.org>; Sun, 20 Aug 2017 06:43:50 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.89)
 (envelope-from <david@tethera.net>)
 id 1djQSd-0004vE-Dy; Sun, 20 Aug 2017 09:40:15 -0400
Received: (nullmailer pid 27195 invoked by uid 1000);
 Sun, 20 Aug 2017 13:43:47 -0000
From: David Bremner <david@tethera.net>
To: Matt Armstrong <marmstrong@google.com>, notmuch@notmuchmail.org
Subject: Re: bug: notmuch show --decrypt leads to SIGSEGV
In-Reply-To: <qf51sobtqgp.fsf@google.com>
References: <qf5shgswst7.fsf@google.com> <877ey4juij.fsf@tethera.net>
 <qf51sobtqgp.fsf@google.com>
Date: Sun, 20 Aug 2017 10:43:47 -0300
Message-ID: <871so6gxrg.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Aug 2017 13:43:51 -0000

Matt Armstrong <marmstrong@google.com> writes:

>> Understood. If you manage to bisect the commit that introduces the
>> problem (I suspect the rearrangement to support gmime-3.0, but you never
>> know), that might be helpful.
>
> David, your suspicions may have been correct.  The bisect came up with
> the following commit.
>
> 1fdc08d0ffab9b211861de5d148d0a79eae840bc is the first bad commit
> commit 1fdc08d0ffab9b211861de5d148d0a79eae840bc
> Author: David Bremner <david@tethera.net>
> Date:   Sun Jul 16 01:01:43 2017 +0200
>
>     cli/crypto: treat failure to create a crypto context as fatal.
>   
>     Silently ignoring signed/encrypted parts seems like the wrong idea,
>     and it also complicates future gmime-3.0 compatibility changes.

Do the messages in question actually verify or decrypt with the code
before this commit, or does notmuch just silently ignore a gmime
failure?  Not that I'm claiming SIGSEGV is an appropriate error
reporting mechanism ;).

d