From: David Bremner <david@tethera.net>
To: Matt Armstrong <marmstrong@google.com>, notmuch@notmuchmail.org
Subject: Re: bug: notmuch show --decrypt leads to SIGSEGV
Date: Sun, 20 Aug 2017 10:43:47 -0300 [thread overview]
Message-ID: <871so6gxrg.fsf@tethera.net> (raw)
In-Reply-To: <qf51sobtqgp.fsf@google.com>
Matt Armstrong <marmstrong@google.com> writes:
>> Understood. If you manage to bisect the commit that introduces the
>> problem (I suspect the rearrangement to support gmime-3.0, but you never
>> know), that might be helpful.
>
> David, your suspicions may have been correct. The bisect came up with
> the following commit.
>
> 1fdc08d0ffab9b211861de5d148d0a79eae840bc is the first bad commit
> commit 1fdc08d0ffab9b211861de5d148d0a79eae840bc
> Author: David Bremner <david@tethera.net>
> Date: Sun Jul 16 01:01:43 2017 +0200
>
> cli/crypto: treat failure to create a crypto context as fatal.
>
> Silently ignoring signed/encrypted parts seems like the wrong idea,
> and it also complicates future gmime-3.0 compatibility changes.
Do the messages in question actually verify or decrypt with the code
before this commit, or does notmuch just silently ignore a gmime
failure? Not that I'm claiming SIGSEGV is an appropriate error
reporting mechanism ;).
d
next prev parent reply other threads:[~2017-08-20 13:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 13:31 [PATCH] crypto: gracefully handle gmime errors Jan Malakhovski
2017-08-31 13:44 ` Jan Malakhovski
2017-09-01 0:10 ` [PATCH] cli: propagate NULL from _mime_node_create, handle it in callers David Bremner
2017-09-01 20:32 ` Jan Malakhovski
2017-08-31 14:22 ` [PATCH] crypto: gracefully handle gmime errors David Bremner
2017-08-31 14:30 ` David Bremner
2017-08-15 17:37 ` bug: notmuch show --decrypt leads to SIGSEGV Matt Armstrong
2017-08-15 18:11 ` David Bremner
2017-08-15 19:10 ` Matt Armstrong
2017-08-15 23:12 ` David Bremner
2017-08-16 16:41 ` Matt Armstrong
2017-08-20 13:43 ` David Bremner [this message]
2017-08-31 15:17 ` [PATCH] crypto: gracefully handle gmime errors Jan Malakhovski
2017-08-31 18:33 ` David Bremner
2017-08-31 22:27 ` David Bremner
2017-08-31 23:20 ` Matt Armstrong
2017-08-31 23:59 ` Jan Malakhovski
2017-11-10 1:05 ` bug: notmuch show --decrypt leads to SIGSEGV David Bremner
2017-08-31 14:34 ` [BUG] gmime-3.0.1 (was: [PATCH] crypto: gracefully handle gmime errors) Jan Malakhovski
2017-09-05 10:54 ` David Bremner
2017-09-05 12:55 ` Jan Malakhovski
2017-09-05 13:38 ` David Bremner
2017-09-05 14:26 ` Jan Malakhovski
2017-09-05 15:26 ` David Bremner
2017-09-05 20:23 ` Jan Malakhovski
2017-09-05 14:04 ` Servilio Afre Puentes
2017-09-05 14:27 ` Jan Malakhovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871so6gxrg.fsf@tethera.net \
--to=david@tethera.net \
--cc=marmstrong@google.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).