From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 33F006DE0C19 for ; Mon, 4 Dec 2017 06:31:01 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.032 X-Spam-Level: X-Spam-Status: No, score=-0.032 tagged_above=-999 required=5 tests=[AWL=-0.032] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l5mZGNLp3ROh for ; Mon, 4 Dec 2017 06:31:00 -0800 (PST) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id 31FF16DE00D3 for ; Mon, 4 Dec 2017 06:31:00 -0800 (PST) Received: from fifthhorseman.net (unknown [38.109.115.130]) by che.mayfirst.org (Postfix) with ESMTPSA id 8FDC3F99B; Mon, 4 Dec 2017 09:30:58 -0500 (EST) Received: by fifthhorseman.net (Postfix, from userid 1000) id EBE992057E; Mon, 4 Dec 2017 09:30:54 -0500 (EST) From: Daniel Kahn Gillmor To: Tomi Ollila , Notmuch Mail Subject: Re: [PATCH 1/5] debian/control: build-depend on python3-sphinx instead of python-sphinx In-Reply-To: References: <20171130094043.2039-1-dkg@fifthhorseman.net> <20171130094043.2039-2-dkg@fifthhorseman.net> <87k1y74zdb.fsf@fifthhorseman.net> Date: Mon, 04 Dec 2017 09:30:51 -0500 Message-ID: <871skar2ec.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 14:31:01 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun 2017-12-03 15:35:04 +0200, Tomi Ollila wrote: > On Thu, Nov 30 2017, Daniel Kahn Gillmor wrote: > >> On Thu 2017-11-30 04:40:39 -0500, Daniel Kahn Gillmor wrote: >>> python2 is going to be deprecated, and python3-sphinx is available all >>> the way back to oldoldstable. let's use the more modern version. >>> --- >>> debian/control | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/debian/control b/debian/control >>> index 20b8a2db..3a624fdc 100644 >>> --- a/debian/control >>> +++ b/debian/control >>> @@ -18,7 +18,7 @@ Build-Depends: >>> python3-all (>=3D 3.1.2-7~), >>> dh-python, >>> dh-elpa (>=3D 1.3), >>> - python-sphinx (>=3D 1.0), >>> + python3-sphinx, >>> ruby, ruby-dev (>>1:1.9.3~), >>> emacs25-nox | emacs25 (>=3D25~) | emacs25-lucid (>=3D25~) | >>> emacs24-nox | emacs24 (>=3D24~) | emacs24-lucid (>=3D24~) | >> >> hm, on further reflection, this one is specifically problematic because >> of the use of: >> >> ${python} -m sphinx.writers.manpage >> >> in ./configure, used to test for the presence of the sphinx module. >> >> This can be fixed by preferring python3 here: >> >> --- a/configure >> +++ b/configure >> @@ -557,7 +557,7 @@ fi >> printf "Checking for python... " >> have_python=3D0 >>=20=20 >> -for name in ${PYTHON} python python2 python3; do >> +for name in ${PYTHON} python3 python python2; do > >> if command -v $name > /dev/null; then >> have_python=3D1 >> python=3D$name >> >> any thoughts or preferences on this? > > I'd like this change. I was going to suggest "${PYTHON}" there > but perhaps if one sets e.g. > > PYTHON=3D'/usr/local/bin/python3 -B -E -u' > > The above would still work (I'd say this is potentially more useful > than supporting whitespace in paths). does it work? i think the -B -E -u will all be tried as possible python implementations separately, no? and $python itself will just get set to /usr/local/bin/python3 with the arguments dropped :( 0 dkg@alice:~$ x=3D"a b c" 0 dkg@alice:~$ for y in ${x} d e; do printf ':%s\n' "$y"; done :a :b :c :d :e 0 dkg@alice:~$=20 While i think this doesn't support Tomi's extended use case, i still think it's the right direction to move in. Does anyone have any objection to the preference order change above? Is there any reason we should be preferring python 2 to python3 as we move forward? --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEOCdgUepHf6PklTkyFJitxsGSMjcFAlolXBwACgkQFJitxsGS MjdzWw//WWGgfSDxPh7fxp0yYGDLBjboGgiSFS5/j5+mYiwbabeJin8x9JZOycwL jAYVAy1baTCKoUdUuAn9sf4rjQfDZJ6+9kvIQClPanqW0RzLdz7sp4gN5QXyNUf5 Xp+WWC3qHxrZeMtOmMJIZQqcyzDoErUktCMgBuSXeMJzweZVSKMsCkoktvUh1I2a xLDk2OA0Ro3rzSleudgGL5Vuwxv2Trmjsj1u85T0ObWFrWmvst0v4E2IxHY4xh2a l2bd967utGQLAskt2ZjA0A0AgiUuRuzeC7FhZ7hfmQ44+a4leA5JXCK2u/mZAUUU j85K8+XDo7nia0zfurgNDAi7ryemtPb45BazQ/z5wiM7iWXKVrdzd5LZjzsphtfd 3KJbRxNrPG38cjAbfugfzFgbwqKoURN9lNJmB4cn7Gq/XPGOmMmZfIj3xlWBBjuN O7jayJuLTRM8LwiOsG5W3KT7pdIr2qGqQn3cV0dvnfK4DgFuo5Are6fAQSdjj5jH SWYf8kO7JtGr+2V2HKon34vrOiFla9lH8qhTxOBUBe6K84vcElBv0erYBhVfj3WN 2kVJq/jz0bN+WkPLqjjl65UdkKN5ROIrPxhR+8IpB60ZsbToODQ9xkp2g982vExV X6rKse3JoEDApeLqP+bn3lxg0egk5WvM/8g/huvmvAXYriS72+o= =htAR -----END PGP SIGNATURE----- --=-=-=--