From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id B603A6DE0203 for ; Wed, 9 May 2018 13:52:25 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.011, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U1b__jbrgKES for ; Wed, 9 May 2018 13:52:25 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id DC08F6DE01F5 for ; Wed, 9 May 2018 13:52:24 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1fGW4T-0006M9-Km; Wed, 09 May 2018 16:52:21 -0400 Received: (nullmailer pid 3877 invoked by uid 1000); Wed, 09 May 2018 20:52:19 -0000 From: David Bremner To: Prof Jayanth R Varma , notmuch@notmuchmail.org Cc: Tomi Ollila Subject: Re: emacs: Split wide window vertically for tree mode message pane In-Reply-To: <877eszb8bo.fsf@JRVARMAPC.i-did-not-set--mail-host-address--so-tickle-me> References: <877eszb8bo.fsf@JRVARMAPC.i-did-not-set--mail-host-address--so-tickle-me> X-List-To: notmuch Date: Wed, 09 May 2018 16:52:19 -0400 Message-ID: <871sekblh8.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 20:52:25 -0000 Prof Jayanth R Varma writes: > This patch modifies the function notmuch-tree-show-message-in in > notmuch-tree.el to split the window vertically while creating a > message pane in tree-mode if the window is wider than 160 (so that > after splitting, the message pane can show the standard 76 > character plain text email lines without wrapping). First, I'm sorry to take so long to review this. A few comments. 1) I'm reluctant to add new features to notmuch without corresponding tests. Currently all of our emacs tests use a standard terminal width (I think 80). Perhaps Tomi knows how hard it would be to override for a single test. 2) I noticed that the horizontal splitting leads to truncation of tag display. So I think not everyone will want this (it would be pretty frustrating to widen the emacs frame to see a full tag list, just to have it truncated). One option would be to control the splitting by a variable specifying the minimum width at which to switch to horizonal splitting. 3) The commit message / NEWS talks about splitting the window vertically, but that seems contrary to the emacs terminology (as evinced by the source code in the patch)