From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, David Edmondson <dme@dme.org>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: When completing tags, offer each tag once
Date: Tue, 02 Feb 2021 15:23:10 -0400 [thread overview]
Message-ID: <871rdyxoip.fsf@tethera.net> (raw)
In-Reply-To: <m2tuquz3pf.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> On Mon, Feb 01 2021, David Edmondson wrote:
>
>> On Monday, 2021-02-01 at 11:49:36 -04, David Bremner wrote:
>>
>>> David Edmondson <dme@dme.org> writes:
>>>>
>>>> +(defun notmuch-search-uniq-tags (tags)
>>>> + (let (result)
>>>> + (mapc (lambda (tag)
>>>> + (unless (member tag result)
>>>> + (push tag result)))
>>>> + tags)
>>>> + result))
>>>
>>> I leave elisp style to others...
>>
>> Me too :-)
>>
>>> Is there some bound on the length of tags? Otherwise this seems like
>>> it's potentially a bit slow?
>>
>> No, there isn't any bound. I'd be surprised to see lists longer than low
>> tens of elements.
>>
>> For similar functionality the dash library provides `-distinct', which
>> uses a lookup table if there are more than 32 elements in the list,
>> claiming that this is the break-point for the hash based approach to be
>> faster.
Maybe delete-dups (subr.el) would be useful here? It is destructive, but
even with a copy (if needed), it should still be faster.
d
next prev parent reply other threads:[~2021-02-02 19:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 14:54 [PATCH] emacs: When completing tags, offer each tag once David Edmondson
2021-02-01 15:49 ` David Bremner
2021-02-01 16:13 ` David Edmondson
2021-02-02 19:09 ` Tomi Ollila
2021-02-02 19:23 ` David Bremner [this message]
2021-02-02 19:53 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rdyxoip.fsf@tethera.net \
--to=david@tethera.net \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).