unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>,
	Gregor Zattler <telegraph@gmx.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: Bug? notmuch-emacs: "All tags" in notmuch-hello does not show all tags
Date: Thu, 20 Jan 2022 15:51:00 -0400	[thread overview]
Message-ID: <871r12gp97.fsf@tethera.net> (raw)
In-Reply-To: <m28t9faaim.fsf@guru.guru-group.fi>

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Sun, Apr 22 2018, Gregor Zattler wrote:
>
>> Hi Tomi, notmuch-emacs developers,
>> * Tomi Ollila <tomi.ollila@iki.fi> [2018-04-21; 20:38]:
>> [...]
>>> That doesn't mean there could not be a bug there, just
>>> that I cannot reproduce it...
>>
>> Thanks for your investigation.
>>
>> I now prepared a minimal example, please extract the archive in
>> /tmp.  It contains a quite minmalistic .notmuch-config, a Maildir
>> with one email and a test script which runs notmuch new, notmuch
>> tag, starts emacs with no configuration and hopefully shows
>> notmuch-hello.[1] Please klick on "show", you'll see only one
>> tag: "spam", klick on "spam" you'll see this one email shown with
>> its four (!) tags: "inbox", "new" and "certaintag" are not shown
>> in "All tags".
>>
>> At least this is what I see with emacs25 and emacs27 and current
>> notmuch.
>>
>> Do you see the same?
>
>
> Yes, I can reproduce -- only "spam" is seen
>
> To look what happened I ran (in notmuch source dir):
>
> $ NOTMUCH_CONFIG=/tmp/.notmuch-config strace -f -e trace=execve,read,write -o ttt ./devel/try-emacs-mua -Q
>
> based on that output:
>
> $ NOTMUCH_CONFIG=/tmp/.notmuch-config notmuch search --output=tags '*'
> certaintag
> inbox
> new
> spam
>
> $ NOTMUCH_CONFIG=/tmp/.notmuch-config notmuch count --batch
> tag:certaintag
> 0
> tag:new
> 0
> tag:spam
> 1
> tag:inbox
> 0
> tag:foobar
> 0
>
> NOTMUCH_CONFIG=/tmp/.notmuch-config notmuch count --batch --exclude=false
> tag:certaintag
> 1
> tag:new
> 1
> tag:spam
> 1
> tag:inbox
> 1
>
> 1
> tag:foobar
> 0
>
> So, currently, whenever count is zero, the tag is now shown in all tags
> listing (but we know we have the tag since queried earlier). But, at least
> in this case we should get real count and have that '--exclude=false' there,
> and then the count is always positive number.
>
> At least some SMOP is required to get this fixed.
>
> Tomi

This bug should be fixed in commit

     cc180507b03d9826c92d48ee91dbd9bb5f15cd56

d

  parent reply	other threads:[~2022-01-20 19:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 16:12 Gregor Zattler
2018-04-21 17:38 ` Tomi Ollila
2018-04-21 22:33   ` Gregor Zattler
2018-04-22  8:52     ` Tomi Ollila
2022-01-05  1:06       ` [PATCH 1/3] test/emacs: add known broken test for hidden tags David Bremner
2022-01-05  1:06         ` [PATCH 2/3] emacs: use --exclude=false when checking for empty searches David Bremner
2022-01-05  1:06         ` [PATCH 3/3] emacs: use --exclude=false when counting total messages David Bremner
2022-01-05 11:41           ` David Bremner
2022-01-20 19:49         ` [PATCH 1/3] test/emacs: add known broken test for hidden tags David Bremner
2022-01-20 19:51       ` David Bremner [this message]
2022-01-22 14:14         ` confirm bug fixed (was: Bug? notmuch-emacs: "All tags" in notmuch-hello does not show all tags) Gregor Zattler
2022-01-22 15:25           ` David Bremner
2022-01-22 17:44             ` Attempt 2 to fix the all-tags display with excludes David Bremner
2022-01-22 17:44               ` [PATCH 1/2] Revert "emacs: use --exclude=false when checking for empty searches" David Bremner
2022-01-22 17:44               ` [PATCH 2/2] emacs: define, use option :disable-excludes for n-h-query-counts David Bremner
2022-01-23 19:00                 ` David Bremner
2022-01-23 19:36                   ` Gregor Zattler
2022-01-24  2:54                     ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r12gp97.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=telegraph@gmx.net \
    --cc=tomi.ollila@iki.fi \
    --subject='Re: Bug? notmuch-emacs: "All tags" in notmuch-hello does not show all tags' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	notmuch.git.git (no URL configured)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).