From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WIziLgmsWWL3YwEAgWs5BA (envelope-from ) for ; Fri, 15 Apr 2022 19:31:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id IJSTKwmsWWLXBwAAauVa8A (envelope-from ) for ; Fri, 15 Apr 2022 19:31:53 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8B7382F3E2 for ; Fri, 15 Apr 2022 19:31:53 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 415F15F70E; Fri, 15 Apr 2022 17:31:51 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 2F70A5F706 for ; Fri, 15 Apr 2022 17:31:48 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 6A9A25FBD7; Fri, 15 Apr 2022 13:31:47 -0400 (EDT) Received: (nullmailer pid 1042654 invoked by uid 1000); Fri, 15 Apr 2022 17:31:46 -0000 From: David Bremner To: michaeljgruber+grubix+git@gmail.com, notmuch@notmuchmail.org Subject: Re: [PATCH] fix build without sfsexp In-Reply-To: <50cd016213f4fbff4330ff27b05761c418bceb4c.1650039637.git.git@grubix.eu> References: <50cd016213f4fbff4330ff27b05761c418bceb4c.1650039637.git.git@grubix.eu> Date: Fri, 15 Apr 2022 14:31:46 -0300 Message-ID: <871qxynth9.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: L34BOOFSGKVQNMCVX55ICBZPINN254SI X-Message-ID-Hash: L34BOOFSGKVQNMCVX55ICBZPINN254SI X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Michael J Gruber X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650043913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=3wDtwub2IkW7Vf0gj+zWfZFMmYPWme2k8//xh97wVo8=; b=L2XltbqGN7kreZJSz7dIE9FQyklQZMvL+RGxpaS+g9k3USUOgc4Anrek3Zouqb/j/nLVbi Nwl6CQVyDtB+68R0txYAYjgibl7kt7XC+enO6/ampUrl7QzYTIIhQovcv0Ggk+FKeANqoq fxvzQ1ShWb5pR647KYa4c6ZaZjhOXnSLsVkRjY8OymnUyNMD9gxj0YbrgoOTID6gBLWwrf ohrPPXp0Yu0qk1oQUyzZy1kSnd+GXyjy5tuqH8u5428q5hY8xbjlZr/TCjw4sZwXwz69Zg fCMjj850jggcsqjt1N3DbfNEamcX/jiuz8K59j5DpFirxHNov9QFuSmi0h4Z2w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650043913; a=rsa-sha256; cv=none; b=rU78XsK4nrapfXvXOORBkY+nCrrsNAhE5W978+hHewGBncCyh7NNnVeE/QIP0GfiJKX+RY nofhArXz38Mojpa39PjX3CBrgelDgpI49QnXbnrDiTvxrwXOB69cpz3Xfpqw1QgseTLwnc G7B5/qwLntzKDIUh1fPNkBCZ12PoUWLW8/ke/4KxFErgzFfx73cg8a2M2GZxFImDlvVS40 QSxShpTi6JtSGhLInRByQCbxlAw2CU9ox7Byf+6uzZwXq3EvXQUEYnFo6VfJOTO2iSqSCj ZOq40aqnfWGuYbv098J1BqlgOItKKM3i5JsRRzkwhirh4e+2uiOLtg+yynvQnw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -3.00 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 8B7382F3E2 X-Spam-Score: -3.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: aPTtDWPeiQjd michaeljgruber+grubix+git@gmail.com writes: > From: Michael J Gruber > > a1d139de ("lib: add sexp: prefix to Xapian (infix) query parser.", > 2022-04-09) introduced sfsexp infix queries. This requires the infix > preprocessor to be built in in a way which does not require sfsexp when > notmuch is built without it. > > Make the preprocessor throw a Xapian error in this case (and fix the > build). > > Signed-off-by: Michael J Gruber > --- > Maybe something like this - I have not test *with* sfsexp, though. Either your patch or mine is OK with me. Yours might be slightly nicer since it gives an actual error message, rather than falling back to the corresponding phrase (generic Xapian query parser behaviour with unknown prefixes). I did test both with and without libsfsexp-dev installed. d