unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Michael J Gruber <michaeljgruber+grubix+git@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: T040 fails on Fedora 39 rebuild
Date: Tue, 15 Aug 2023 20:53:16 -0300	[thread overview]
Message-ID: <871qg3vp5f.fsf@motzkin.cs.unb.ca> (raw)
In-Reply-To: <87sf8kk28s.fsf@tethera.net>

David Bremner <david@tethera.net> writes:

> Michael J Gruber <michaeljgruber+grubix+git@gmail.com> writes:
>
>> At first I thought we (notmuch) might have a flushing problem or such,
>> which we should prevent. But this clearly looks like a glib2
>> regression now which caused others' CI to fail, too. At least you're
>> prepared in case of incoming reports now ;-)
>
> I am seeing related (but less obnoxious) failures with glib 2.77.1 and
> 2.77.2: namely the comment at the beginning of the file is gone and the
> blank lines between groups are gone. Ignoring whitespace variance is
> easy enough, but the missing comment at the beginning indicates either a
> glib regression or notmuch doing it wrong.
>

Seems like a glib regression, unless there is something forbidden about
the following. Sigh, I guess I need to register for an account to report
a glib bug.

#include <glib.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>

int main(int argc, char** argv){
  GKeyFile *file;
  size_t length;
  char *data, *filename;
  GError *error = NULL;
  
  file = g_key_file_new ();
  g_key_file_set_comment (file, NULL, NULL, "top comment", NULL);
  g_key_file_set_value (file, "section", "dummy_key", "dummy_val");
  g_key_file_remove_key (file, "section", "dummy_key", NULL);
  g_key_file_set_comment (file,"section",NULL, "section comment",NULL);

  data = g_key_file_to_data (file, &length, NULL);
  if (data == NULL) {
    fprintf (stderr, "Out of memory.\n");
    return 1;
  }

  puts(data);
  
}

  parent reply	other threads:[~2023-08-15 23:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20 18:54 T040 fails on Fedora 39 rebuild Michael J Gruber
2023-07-20 19:33 ` Michael J Gruber
2023-07-21  1:40   ` David Bremner
2023-07-21  5:55     ` Michael J Gruber
     [not found]       ` <87sf8kk28s.fsf@tethera.net>
2023-08-15 23:53         ` David Bremner [this message]
2023-08-16  0:23           ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qg3vp5f.fsf@motzkin.cs.unb.ca \
    --to=david@tethera.net \
    --cc=michaeljgruber+grubix+git@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).