From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id BCD7A431FC3 for ; Fri, 27 Nov 2009 21:23:13 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jy48-htvpV9b for ; Fri, 27 Nov 2009 21:23:13 -0800 (PST) Received: from mail-pw0-f51.google.com (mail-pw0-f51.google.com [209.85.160.51]) by olra.theworths.org (Postfix) with ESMTP id 0C17A431FBC for ; Fri, 27 Nov 2009 21:23:12 -0800 (PST) Received: by pwj10 with SMTP id 10so1283587pwj.30 for ; Fri, 27 Nov 2009 21:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:to:cc:subject :in-reply-to:references:date:message-id:mime-version:content-type; bh=QJ3MBNx6QQ4a0IDzu/mAE0W3uol8VjU9USGivV6XrOk=; b=wozLRGWZdYdm/fiGZo451kCkD+nyxvXFtzFXSCxCm/DoJF8tpLZJw9kdG5NOcBjyj6 DAW1Jd/CGbfloJ32zno5wnyVtAVr9IKSymWwGyWsq4YfQYIQAizJlFN5ggwPungZNbqO 26ZH4Ua5o0rM6qqAGgZeLoaf11ilFxe8xQOAo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; b=S19bzXRlWA/grI8emvXnRE43hj1joyAj+s8SKElijAyYEDWBK0RkU6ECfOZBPcJkQU fw89H52r+yAjqQUIeAN6oLG94U2T4DT19bY4JvCzz39WjBau0YsJ6GXX4rSUNJZxHSkQ cRJ6scIKG3n3he9ZWAxwxZyEraEqRyjsKEoZM= Received: by 10.114.3.29 with SMTP id 29mr3064921wac.208.1259385792295; Fri, 27 Nov 2009 21:23:12 -0800 (PST) Received: from fortitudo (70-36-144-85.dsl.dynamic.sonic.net [70.36.144.85]) by mx.google.com with ESMTPS id 21sm1683436pxi.12.2009.11.27.21.23.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 27 Nov 2009 21:23:11 -0800 (PST) Received: from alexbl (uid 1001) (envelope-from alexbl@fortitudo.i-did-not-set--mail-host-address--so-tickle-me) id 7378 by fortitudo (DragonFly Mail Agent) Fri, 27 Nov 2009 21:23:19 -0800 From: Alexander Botero-Lowry To: Carl Worth , camalot@picnicpark.org, notmuch@notmuchmail.org In-Reply-To: <87iqcvtest.fsf@yoom.home.cworth.org> References: <1259328615-1445-1-git-send-email-camalot@picnicpark.org> <1259328615-1445-2-git-send-email-camalot@picnicpark.org> <1259328615-1445-3-git-send-email-camalot@picnicpark.org> <1259328615-1445-4-git-send-email-camalot@picnicpark.org> <1259328615-1445-5-git-send-email-camalot@picnicpark.org> <87iqcvtest.fsf@yoom.home.cworth.org> Date: Fri, 27 Nov 2009 21:23:19 -0800 Message-ID: <86bpinql2w.fsf@fortitudo.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Keith Amidon Subject: Re: [PATCH 4/9] Factor out message buffer mgmt from notmuch-show-view-all-mime-parts X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Nov 2009 05:23:13 -0000 On Fri, 27 Nov 2009 21:10:42 -0800, Carl Worth wrote: > On Fri, 27 Nov 2009 05:30:10 -0800, camalot@picnicpark.org wrote: > > From: Keith Amidon > > > > The ability to temporarily create a buffer containing only the > > contents of the currently selected message in notmuch show mode is > > generally useful. This commit factors the majority of the code > > required to do so out of notmuch-show-view-all-mime-parts into a macro > > called with-current-notmuch-show-message and rewrites the original > > function in terms of the macro. > > > > A future set of commits will provide additional functionality using > > the macro as well. > > Hurrah! I'm glad to see that you are wholly more capable with emacs lisp > than I am. I knew of lisp macros of course, but didn't know the actual > syntax for writing one. > I actually did something similar for my html support. except I used `with-temp-buffer' macro instead. I'm hoping that the need to ever actually use the raw message buffer directly goes away, so I think it would be better to use with-temp-buffer in your macro instead of the named buffer. Alex