unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Alexander Botero-Lowry <alex.boterolowry@gmail.com>
To: Carl Worth <cworth@cworth.org>,
	camalot@picnicpark.org, notmuch@notmuchmail.org
Cc: Keith Amidon <keith@nicira.com>
Subject: Re: [PATCH 4/9] Factor out message buffer mgmt from notmuch-show-view-all-mime-parts
Date: Fri, 27 Nov 2009 21:23:19 -0800	[thread overview]
Message-ID: <86bpinql2w.fsf@fortitudo.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87iqcvtest.fsf@yoom.home.cworth.org>

On Fri, 27 Nov 2009 21:10:42 -0800, Carl Worth <cworth@cworth.org> wrote:
> On Fri, 27 Nov 2009 05:30:10 -0800, camalot@picnicpark.org wrote:
> > From: Keith Amidon <keith@nicira.com>
> > 
> > The ability to temporarily create a buffer containing only the
> > contents of the currently selected message in notmuch show mode is
> > generally useful.  This commit factors the majority of the code
> > required to do so out of notmuch-show-view-all-mime-parts into a macro
> > called with-current-notmuch-show-message and rewrites the original
> > function in terms of the macro.
> > 
> > A future set of commits will provide additional functionality using
> > the macro as well.
> 
> Hurrah! I'm glad to see that you are wholly more capable with emacs lisp
> than I am. I knew of lisp macros of course, but didn't know the actual
> syntax for writing one.
> 
I actually did something similar for my html support. except I used
`with-temp-buffer' macro instead. I'm hoping that the need to ever
actually use the raw message buffer directly goes away, so I think it
would be better to use with-temp-buffer in your macro instead of the
named buffer.

Alex

  reply	other threads:[~2009-11-28  5:23 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-27 13:30 Show mode enhancements camalot
2009-11-27 13:30 ` [PATCH 1/9] Explicitly require the message library camalot
2009-11-27 13:30   ` [PATCH 2/9] Adjust autoload comments camalot
2009-11-27 13:30     ` [PATCH 3/9] Add key binding for notmuch-search in show-mode camalot
2009-11-27 13:30       ` [PATCH 4/9] Factor out message buffer mgmt from notmuch-show-view-all-mime-parts camalot
2009-11-27 13:30         ` [PATCH 5/9] Forward individual messages using message-forward camalot
2009-11-27 13:30           ` [PATCH 6/9] Reply to individual messages using message library camalot
2009-11-27 13:30             ` [PATCH 7/9] Key bindings for message library based replies camalot
2009-11-27 13:30               ` [PATCH 8/9] Provide ability to save attachments camalot
2009-11-27 13:30                 ` [PATCH 9/9] Key binding rearrangement for save attachments in show mode camalot
2009-11-28  5:30                   ` Carl Worth
2009-11-28  5:28                 ` [PATCH 8/9] Provide ability to save attachments Carl Worth
     [not found]             ` <87bpiongh5.fsf@linux.vnet.ibm.com>
2009-11-27 16:48               ` [PATCH 6/9] Reply to individual messages using message library Keith Amidon
2009-11-28  5:22             ` Carl Worth
2009-11-29  6:09               ` Keith Amidon
2009-11-28  5:15           ` [PATCH 5/9] Forward individual messages using message-forward Carl Worth
2009-11-28 17:32             ` Keith Amidon
2009-11-28 17:49               ` Carl Worth
2009-11-28 21:14                 ` Keith Amidon
2009-11-28  5:10         ` [PATCH 4/9] Factor out message buffer mgmt from notmuch-show-view-all-mime-parts Carl Worth
2009-11-28  5:23           ` Alexander Botero-Lowry [this message]
2009-11-28  5:06     ` [PATCH 2/9] Adjust autoload comments Carl Worth
2009-11-28 17:27       ` Keith Amidon
2009-11-28 17:36         ` Carl Worth
2009-11-30 20:38         ` James Rowe
2009-12-04  1:04           ` Carl Worth
2009-12-04  1:24             ` Jameson Graef Rollins
2009-12-04 17:27               ` Carl Worth
2009-12-04  4:44             ` James Rowe
2009-12-04  1:07           ` Carl Worth
2009-12-17 17:17             ` James Rowe
2009-12-17 17:52               ` Carl Worth
2009-11-28  5:03   ` [PATCH 1/9] Explicitly require the message library Carl Worth
2009-11-28  4:18 ` Show mode enhancements Carl Worth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86bpinql2w.fsf@fortitudo.i-did-not-set--mail-host-address--so-tickle-me \
    --to=alex.boterolowry@gmail.com \
    --cc=camalot@picnicpark.org \
    --cc=cworth@cworth.org \
    --cc=keith@nicira.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).