From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org
Subject: [PATCH 1/2] cli: add mechanism for running user configurable hooks
Date: Fri, 2 Dec 2011 23:00:05 +0200 [thread overview]
Message-ID: <7fbe6befcf31881a9bca672f55b93501249a220c.1322859389.git.jani@nikula.org> (raw)
Add support functions for running hooks configurable in the notmuch config
file. The hooks will be run using system(1).
TODO:
* Move notmuch_run_hook() out of notmuch-new.c. It's there and static only
because the first user will be there.
* Consider merging this with the following patch, as this is slightly
artificial as it is.
Signed-off-by: Jani Nikula <jani@nikula.org>
---
notmuch-client.h | 7 +++++++
notmuch-config.c | 21 +++++++++++++++++++++
notmuch-new.c | 25 +++++++++++++++++++++++++
3 files changed, 53 insertions(+), 0 deletions(-)
diff --git a/notmuch-client.h b/notmuch-client.h
index b50cb38..5e2fed2 100644
--- a/notmuch-client.h
+++ b/notmuch-client.h
@@ -87,6 +87,10 @@ typedef struct notmuch_show_params {
int decrypt;
} notmuch_show_params_t;
+typedef enum {
+ NOTMUCH_HOOK_PLACEHOLDER,
+} notmuch_hook_t;
+
/* There's no point in continuing when we've detected that we've done
* something wrong internally (as opposed to the user passing in a
* bogus value).
@@ -235,6 +239,9 @@ void
notmuch_config_set_maildir_synchronize_flags (notmuch_config_t *config,
notmuch_bool_t synchronize_flags);
+const char *
+notmuch_config_get_hook (notmuch_config_t *config, notmuch_hook_t hook);
+
notmuch_bool_t
debugger_is_active (void);
diff --git a/notmuch-config.c b/notmuch-config.c
index 1a7ed58..8f1a038 100644
--- a/notmuch-config.c
+++ b/notmuch-config.c
@@ -608,6 +608,27 @@ notmuch_config_set_new_tags (notmuch_config_t *config,
config->new_tags = NULL;
}
+const char *
+notmuch_config_get_hook (notmuch_config_t *config, notmuch_hook_t hook)
+{
+ char *command;
+ const char *group, *key;
+
+ switch (hook) {
+ default:
+ INTERNAL_ERROR ("Unknown hook %d\n.", hook);
+ }
+
+ command = g_key_file_get_string (config->key_file, group, key, NULL);
+ if (command) {
+ char *p = command;
+ command = talloc_strdup (config, command);
+ free (p);
+ }
+
+ return command;
+}
+
/* Given a configuration item of the form <group>.<key> return the
* component group and key. If any error occurs, print a message on
* stderr and return 1. Otherwise, return 0.
diff --git a/notmuch-new.c b/notmuch-new.c
index 81a9350..0c70e64 100644
--- a/notmuch-new.c
+++ b/notmuch-new.c
@@ -795,6 +795,31 @@ _remove_directory (void *ctx,
notmuch_directory_destroy (directory);
}
+static int
+notmuch_run_hook (notmuch_config_t *config, notmuch_hook_t hook)
+{
+ const char *command;
+ int r;
+
+ command = notmuch_config_get_hook (config, hook);
+ if (!command)
+ return NOTMUCH_STATUS_SUCCESS; /* It's okay not to have a hook */
+
+ r = system(command);
+ if (r) {
+ if (WIFSIGNALED(r))
+ fprintf(stderr, "hook '%s' terminated with signal %d\n",
+ command, WTERMSIG(r));
+ else
+ fprintf(stderr, "hook '%s' failed with status %d\n",
+ command, WEXITSTATUS(r));
+
+ r = NOTMUCH_STATUS_FILE_ERROR; /* FIXME */
+ }
+
+ return r;
+}
+
int
notmuch_new_command (void *ctx, int argc, char *argv[])
{
--
1.7.5.4
next reply other threads:[~2011-12-02 21:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 21:00 Jani Nikula [this message]
2011-12-02 21:00 ` [PATCH 2/2] cli: add support for running notmuch new pre and post hooks Jani Nikula
2011-12-02 21:05 ` [PATCH 1/2] cli: add mechanism for running user configurable hooks Jani Nikula
2011-12-03 23:16 ` [PATCH v2 1/2] cli: introduce the concept of user defined hooks Jani Nikula
2011-12-03 23:16 ` [PATCH v2 2/2] cli: add support for pre and post notmuch new hooks Jani Nikula
2011-12-04 4:00 ` Austin Clements
2011-12-04 19:36 ` Jani Nikula
2011-12-04 19:54 ` Tom Prince
2011-12-04 16:46 ` Tom Prince
2011-12-04 19:56 ` Jani Nikula
2011-12-04 3:42 ` [PATCH v2 1/2] cli: introduce the concept of user defined hooks Austin Clements
2011-12-04 12:35 ` Jani Nikula
2011-12-04 16:41 ` Austin Clements
2011-12-06 13:22 ` [PATCH v3 0/2] notmuch hooks Jani Nikula
2011-12-06 13:22 ` [PATCH v3 1/2] cli: introduce the concept of user defined hooks Jani Nikula
2011-12-06 13:30 ` Jani Nikula
2011-12-06 13:22 ` [PATCH v3 2/2] cli: add support for pre and post notmuch new hooks Jani Nikula
2011-12-07 2:27 ` [PATCH v3 0/2] notmuch hooks Jameson Graef Rollins
2011-12-07 19:42 ` Jani Nikula
2011-12-07 22:13 ` Jameson Graef Rollins
2011-12-08 8:49 ` Tomi Ollila
2011-12-08 16:29 ` Jameson Graef Rollins
2011-12-07 2:47 ` Jameson Graef Rollins
2011-12-07 3:16 ` Tom Prince
2011-12-07 18:05 ` Jani Nikula
2011-12-07 18:10 ` Jameson Graef Rollins
2011-12-07 20:11 ` Austin Clements
2011-12-08 22:48 ` [PATCH v4 0/3] " Jani Nikula
2011-12-08 22:48 ` [PATCH v4 1/3] cli: introduce the concept of user defined hooks Jani Nikula
2011-12-08 23:34 ` Austin Clements
2011-12-09 13:55 ` Jani Nikula
2011-12-09 15:59 ` Austin Clements
2011-12-08 22:48 ` [PATCH v4 2/3] cli: add support for pre and post notmuch new hooks Jani Nikula
2011-12-08 22:48 ` [PATCH v4 3/3] test: add tests for hooks Jani Nikula
2011-12-10 22:04 ` [PATCH v4 0/3] notmuch hooks Jameson Graef Rollins
2011-12-11 18:29 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fbe6befcf31881a9bca672f55b93501249a220c.1322859389.git.jani@nikula.org \
--to=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).