Final call for news for 0.18

Final call for news for 0.18

[David Bremner]

We've had a quiet freeze for a week or so, so I think we're probably
ready to release. Per Jani's suggestion, I made a "tl;dr" summary for
the NEWS. Barring last minute bugs, I'd like to release this weekend,
so please send me any NEWS comments ASAP.

d

[PATCH] NEWS: add overview section for 0.18

[David Bremner]

This mentions the things I (subjectively) thought were most likely to
either annoy people or make it worth upgrading.
---
 NEWS | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/NEWS b/NEWS
index 06876e0..132c687 100644
--- a/NEWS
+++ b/NEWS
@@ -1,6 +1,19 @@
 Notmuch 0.18~rc0 (2014-04-22)
 =============================
 
+Overview
+--------
+
+This new release of includes some enhancements to searching for
+messages by filesystem location (`folder:` and `path:` prefixes under
+*General* below).  Saved searches in *Emacs* have also been enhanced
+to allow distinct search orders for each one.  Another enhancement to
+the *Emacs* interface is that replies to encrypted messages are now
+encrypted, reducing the risk of unintentional information disclosure.
+The default dump output format has changed to the more robust
+`batch-tag` format. The previously deprecated parsing of single
+message mboxes is removed. For detailed release notes, see below.
+
 General
 -------
 
-- 
1.9.2

RE: Final call for news for 0.18

[Felipe Contreras]

David Bremner wrote:
> We've had a quiet freeze for a week or so, so I think we're probably
> ready to release. Per Jani's suggestion, I made a "tl;dr" summary for
> the NEWS. Barring last minute bugs, I'd like to release this weekend,
> so please send me any NEWS comments ASAP.

What about the vim changes?

http://mid.gmane.org/1398289784-18203-1-git-send-email-felipe.contreras@gmail.com

-- 
Felipe Contreras

[PATCH 0/5] some more news for 0.18

[Jani Nikula]

Hi David, here's some more news; feel free to drop any that you don't
think are newsworthy.

BR,
Jani.


Jani Nikula (5):
  NEWS: notmuch insert respects maildir.synchronize_flags
  NEWS: emacs: push mark before signature on reply
  NEWS: cli exit status codes
  NEWS: message piping working directory
  NEWS: insert and new refuse invalid tags

 NEWS | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

-- 
1.9.2

[PATCH 1/5] NEWS: notmuch insert respects maildir.synchronize_flags

[Jani Nikula]

---
 NEWS | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/NEWS b/NEWS
index 06876e0a7df1..b7a1b5f645e5 100644
--- a/NEWS
+++ b/NEWS
@@ -71,6 +71,11 @@ Command-Line Interface
 
   This option suppresses the progress and summary reports.
 
+`notmuch insert` respects maildir.synchronize_flags config option
+
+  Do not synchronize tags to maildir flags in `notmuch insert` if the
+  user does not want it.
+
 Emacs Interface
 ---------------
 
-- 
1.9.2

[PATCH 2/5] NEWS: emacs: push mark before signature on reply

[Jani Nikula]

---
 NEWS | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/NEWS b/NEWS
index b7a1b5f645e5..b635b46aeebc 100644
--- a/NEWS
+++ b/NEWS
@@ -170,6 +170,12 @@ Replies to encrypted messages will be encrypted by default
   encrypt replies to encrypted messages. This should make it less
   likely to accidentally reply to encrypted messages in plain text.
 
+Reply pushes mark before signature
+
+  We push mark and set point on reply so that the user can easily cut
+  the quoted text. The mark is now pushed before the signature, if
+  any, instead of end of buffer so the signature is preserved.
+
 nmbug
 -----
 
-- 
1.9.2

[PATCH 3/5] NEWS: cli exit status codes

[Jani Nikula]

---
 NEWS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/NEWS b/NEWS
index b635b46aeebc..74a68c573f03 100644
--- a/NEWS
+++ b/NEWS
@@ -76,6 +76,13 @@ Command-Line Interface
   Do not synchronize tags to maildir flags in `notmuch insert` if the
   user does not want it.
 
+The commands set consistent exit status codes on failures
+
+  The cli commands now consistently set exit status of 1 on failures,
+  except where explicitly otherwise noted. The notable expections are
+  the status codes for format version mismatches for commands that
+  support formatted output.
+
 Emacs Interface
 ---------------
 
-- 
1.9.2

[PATCH 4/5] NEWS: message piping working directory

[Jani Nikula]

---
 NEWS | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/NEWS b/NEWS
index 74a68c573f03..3d42d08684be 100644
--- a/NEWS
+++ b/NEWS
@@ -183,6 +183,12 @@ Reply pushes mark before signature
   the quoted text. The mark is now pushed before the signature, if
   any, instead of end of buffer so the signature is preserved.
 
+Message piping uses the originating buffer's working directory
+
+  `notmuch-show-pipe-message` now uses the originating buffer's
+  current default directory instead of that of the `*notmuch-pipe*`
+  buffer's.
+
 nmbug
 -----
 
-- 
1.9.2

[PATCH 5/5] NEWS: insert and new refuse invalid tags

[Jani Nikula]

---
 NEWS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/NEWS b/NEWS
index 3d42d08684be..1948072ae43c 100644
--- a/NEWS
+++ b/NEWS
@@ -83,6 +83,13 @@ The commands set consistent exit status codes on failures
   the status codes for format version mismatches for commands that
   support formatted output.
 
+Bug fix for checking configured new.tags for invalid tags
+
+  `notmuch new` and `notmuch insert` now check the user configured
+  new.tags for invalid tags, and refuse to apply them, similar to
+  `notmuch tag`. Invalid tags are currently the empty string and tags
+  starting with `-`.
+
 Emacs Interface
 ---------------
 
-- 
1.9.2

RE: Final call for news for 0.18

[Tomi Ollila]

On Thu, May 01 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:

> David Bremner wrote:
>> We've had a quiet freeze for a week or so, so I think we're probably
>> ready to release. Per Jani's suggestion, I made a "tl;dr" summary for
>> the NEWS. Barring last minute bugs, I'd like to release this weekend,
>> so please send me any NEWS comments ASAP.
>
> What about the vim changes?
>
> http://mid.gmane.org/1398289784-18203-1-git-send-email-felipe.contreras@gmail.com

I was going to review these after 0.18 release as the freeze was announced
to be Apri 21th(*) and these patches in question was sent April 24th, without
any request to consider these for 0.18...

(*) This freeze was announced April 14th (see id:8761mcxjhc.fsf@zancas.localnet
or http://mid.gmane.org/8761mcxjhc.fsf@zancas.localnet )

In general these patches:

id:1398289784-18203-2-git-send-email-felipe.contreras@gmail.com
id:1398289784-18203-3-git-send-email-felipe.contreras@gmail.com
id:1398289784-18203-4-git-send-email-felipe.contreras@gmail.com

has something lacking in the commit messages; none of these indicate that
these are vim patches in the subject line.  For 1/3 I'd have liked to see
some potentially understandable explanation why the change was done instead
of "Seems it never really worked." -- the change looks a bit strange
(probably due to only the context seen).  Commit message for 2/3 might be
tolerable if it were prefixed with vim: -- and the same applies to 3/3
(in 3/3 I don't understand the change and I don't use vim so I don't know
how to test so It would be nice to get someone else (or two) to report
their experience with these patches applied in their notmuch-vim environment)

Also NEWS for these changes are missing.

I personally don't see these patches being important enough to hinder
0.18 release timeline -- these patches should just have come earlier...
... but if you had a good case, fix these things (quickly!) and had
strong backing from some other notmuch-vim users I could see a small
chance of these being part of the next release...


Tomi


PS: does vim frontend lack id:message-id feature -- the above http link
to gmane was just useless to me, which meant I had to use extra steps
to reach the emails (which sometimes if not often leads me just to drop
the issue there...). If it is lacking and SomeOne(™) proposes id:msgid
handling to notmuch-wim I promise to review that right away :D


> -- 
> Felipe Contreras

Re: [PATCH 5/5] NEWS: insert and new refuse invalid tags

[David Bremner]

Jani Nikula <jani@nikula.org> writes:

> ---
>  NEWS | 7 +++++++
>  1 file changed, 7 insertions(+)

pushed jani's 5 patches, and an amended version of mine

RE: Final call for news for 0.18

[Felipe Contreras]

Tomi Ollila wrote:
> In general these patches:
> 
> id:1398289784-18203-2-git-send-email-felipe.contreras@gmail.com
> id:1398289784-18203-3-git-send-email-felipe.contreras@gmail.com
> id:1398289784-18203-4-git-send-email-felipe.contreras@gmail.com
> 
> has something lacking in the commit messages; none of these indicate that
> these are vim patches in the subject line.

Agh, I ported them from my standalone repo and forgot to do that.

> Also NEWS for these changes are missing.

Shouldn't the NEWS be written by the maintainers? In fact, aren't they
the ones that decide if something is worth mentioning in the NEWS or
not?

> I personally don't see these patches being important enough to hinder
> 0.18 release timeline --

Well, if your mails had ever been rejected from vger.kernel.org because
of the format you might see that.

> these patches should just have come earlier...

Yes.

> ... but if you had a good case, fix these things (quickly!) and had
> strong backing from some other notmuch-vim users I could see a small
> chance of these being part of the next release...

All right.

> PS: does vim frontend lack id:message-id feature --

What feature?

-- 
Felipe Contreras

RE: Final call for news for 0.18

[David Bremner]

Felipe Contreras <felipe.contreras@gmail.com> writes:

>
>> Also NEWS for these changes are missing.
>
> Shouldn't the NEWS be written by the maintainers? In fact, aren't they
> the ones that decide if something is worth mentioning in the NEWS or
> not?
>

Hi Felipe;

I guess for the Vim/ruby stuff you're best positioned to judge what is
important.  We run a kind of pyramid scheme: people generally submit
short summaries of their own user visible changes; this is the first
release that I've written a short summary of that.

d

RE: Final call for news for 0.18

[Tomi Ollila]

On Fri, May 02 2014, David Bremner <david@tethera.net> wrote:

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>>
>>> Also NEWS for these changes are missing.
>>
>> Shouldn't the NEWS be written by the maintainers? In fact, aren't they
>> the ones that decide if something is worth mentioning in the NEWS or
>> not?
>>
>
> Hi Felipe;
>
> I guess for the Vim/ruby stuff you're best positioned to judge what is
> important.  We run a kind of pyramid scheme: people generally submit
> short summaries of their own user visible changes; this is the first
> release that I've written a short summary of that.

That said (by David) I'm happy w/ your revised patch set, provided you
also add a NEWS patch, on top of 'release' branch.


For writing NEWS patch: NEWS patches should be written by the one authoring
the corresponding change. And everyone else judges whether the NEWS are
good enough, and the iteration goes on. Finally unless NEWS are
satisfactionary, the patches in question are reverted from the repository >;D
I.e. ease the work of maintainers by providing relevant NEWS by the time of
release :D

>
> d

Tomi

RE: Final call for news for 0.18

[Tomi Ollila]

On Fri, May 02 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:

> Tomi Ollila wrote:
>
>> PS: does vim frontend lack id:message-id feature --
>
> What feature?

In Emacs MUA, when one presses ENTER (or clicks mouse) on top of
text containing id:<message-id> the client opens that particular message.

> -- 
> Felipe Contreras


Tomi

Re: Final call for news for 0.18

[David Bremner]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

David Bremner <david@tethera.net> writes:

> We've had a quiet freeze for a week or so, so I think we're probably
> ready to release. Per Jani's suggestion, I made a "tl;dr" summary for
> the NEWS. Barring last minute bugs, I'd like to release this weekend,
> so please send me any NEWS comments ASAP.
>
> d

I have pushed the vim changes, so we'll have a short freeze extension
for 48h.  We will release on May 6, unless a bug that causes data loss
is revealed in the interim.

d

[-- Attachment #2: Type: application/pgp-signature, Size: 647 bytes --]

Re: Final call for news for 0.18

[Felipe Contreras]

David Bremner wrote:
> David Bremner <david@tethera.net> writes:
> 
> > We've had a quiet freeze for a week or so, so I think we're probably
> > ready to release. Per Jani's suggestion, I made a "tl;dr" summary for
> > the NEWS. Barring last minute bugs, I'd like to release this weekend,
> > so please send me any NEWS comments ASAP.
> 
> I have pushed the vim changes, so we'll have a short freeze extension
> for 48h.  We will release on May 6, unless a bug that causes data loss
> is revealed in the interim.

Thanks. I looked at the debian changelog and it looks correct, I don't
think there is much point in mentioning the fix in the NEWS.

-- 
Felipe Contreras