From: Hannu Hartikainen <hannu@hrtk.in>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Cc: David Edmondson <dme@dme.org>
Subject: Re: [PATCH v3 1/2] cli/show: add --format=pretty
Date: Tue, 13 Jul 2021 14:50:28 +0300 [thread overview]
Message-ID: <60ed7e05.1c69fb81.5aa4e.22d0@mx.google.com> (raw)
In-Reply-To: <878s2a8qac.fsf@tethera.net>
Thanks for reviewing the patch!
On Tue, 13 Jul 2021 07:24:43 -0300, David Bremner <david@tethera.net> wrote:
> David Bremner <david@tethera.net> writes:
> > I don't know what g_mime_message_get_message_id will return if there is
> > no message-id, but that case can and does arise.
It returns null and the printing function prints out `(null)` IIRC so
it's not a crash (I checked that), but good point nonetheless.
> I expect that would require somehow making the notmuch_database_t object
> available inside the sprinter. We want this for at least one other
> feature request (configurable headers in json / sexpr output), so it's
> not as much of a "waste" of effort as it might seem at first.
That's good to know. I was afraid of making big changes for no reason. I
think I had a version that added a function parameter but thought it's
too ugly and complicated to submit.
> The options are adding extra arguments to functions and stashing a
> copy of the pointer in some struct (perhaps the sprinter struct).
I'll see if I find a good way to do the latter when I have time. Thanks
for the pointers!
Hannu
next prev parent reply other threads:[~2021-07-13 11:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 20:38 [PATCH] cli/show: add --format=pretty Hannu Hartikainen
2021-06-22 12:34 ` [PATCH] cli/show: add --color/--no-color Hannu Hartikainen
2021-07-12 8:38 ` Yet another revision of --format=pretty Hannu Hartikainen
2021-07-12 8:38 ` [PATCH v3 1/2] cli/show: add --format=pretty Hannu Hartikainen
2021-07-12 23:40 ` David Bremner
2021-07-13 10:24 ` David Bremner
2021-07-13 11:50 ` Hannu Hartikainen [this message]
2021-07-12 8:38 ` [PATCH v3 2/2] cli/show: add color for --format=pretty Hannu Hartikainen
2021-07-12 23:19 ` Yet another revision of --format=pretty David Bremner
2021-07-13 12:07 ` Hannu Hartikainen
2021-07-02 20:31 ` [PATCH v2] cli/show: add --format=pretty Hannu Hartikainen
2021-07-04 9:40 ` Tomi Ollila
2021-07-04 11:54 ` Hannu Hartikainen
2021-07-04 14:38 ` [PATCH] " David Bremner
2021-07-05 13:31 ` Hannu Hartikainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60ed7e05.1c69fb81.5aa4e.22d0@mx.google.com \
--to=hannu@hrtk.in \
--cc=david@tethera.net \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).