From: Hannu Hartikainen <hannu@hrtk.in>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] lib: consider all instances of Delivered-To header
Date: Mon, 28 Jun 2021 10:11:32 +0300 [thread overview]
Message-ID: <60d97625.1c69fb81.bb41d.6abc@mx.google.com> (raw)
In-Reply-To: <874kdkzfxk.fsf@tethera.net>
Thanks for the review! Please consider the patch obsolete, I'll submit a
v2 later with the comments addressed.
On Sat, 26 Jun 2021 14:36:23 -0300, David Bremner <david@tethera.net> wrote:
> Hannu Hartikainen <hannu@hrtk.in> writes:
> > + * Similarly, multiple instances of Delivered-To may be present. We
> > + * concatenate them so the one with highest priority may be picked.
> > */
>
> Highest priority seems a bit vague here. Do you mean most recent?
I mean that the address configured as `primary_email` is chosen over
those configured as `other_email` if both are present. Basically, let
`user_address_in_string` in notmuch-reply.c do its thing. AFAICT the
addresses in `other_email` are checked in sequence so the first matching
one is chosen, ie. they also have a priority. Not sure if that is
intended and documented or if it could change later, so I didn't want to
go into specifics in the comment.
> The idiomatic (for notmuch) thing to do for a bug fix is first to add a
> test with "test_subtest_known_broken", then to remove that line in the
> commit you fix the bug.
So it's best to have a commit with only the (broken) test first as
opposed to adding the fix and the test in the same commit? Ok, I'll do
that.
Hannu
next prev parent reply other threads:[~2021-06-28 7:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 10:29 [PATCH] lib: consider all instances of Delivered-To header Hannu Hartikainen
2021-06-23 10:58 ` Michael J Gruber
2021-06-23 12:15 ` Hannu Hartikainen
2021-06-26 17:36 ` David Bremner
2021-06-28 7:11 ` Hannu Hartikainen [this message]
2021-07-02 9:13 ` [PATCH v2 1/2] reply: add test for multiple Delivered-To headers Hannu Hartikainen
2021-07-02 9:13 ` [PATCH v2 2/2] lib: consider all instances of Delivered-To header Hannu Hartikainen
2021-08-30 1:13 ` [PATCH v2 1/2] reply: add test for multiple Delivered-To headers David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60d97625.1c69fb81.bb41d.6abc@mx.google.com \
--to=hannu@hrtk.in \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).