From: Mikhail <mp39590@gmail.com>
To: David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] tests: add compatibility layer
Date: Wed, 21 Dec 2016 17:56:27 +0300 [thread overview]
Message-ID: <59549208.20161221175627@gmail.com> (raw)
In-Reply-To: <87tw9y2q8i.fsf@rocinante.cs.unb.ca>
David wrote 21.12.2016, 1:24:45:
> mp39590@gmail.com writes:
>>
>> +# OS independent functions
>> +#
>> +# Alias native BSD utilities to usable GNU equivalents.
>> +case `uname` in
>> +FreeBSD)
>> + # allow using aliases in scripts
>> + shopt -s expand_aliases
>> +
>> + alias date=gdate
>> + alias base64=gbase64
>> + alias gdb=$BSD_GDB
>> + alias wc=gwc
>> + alias sed="gsed"
>> + alias sha256sum=gsha256sum
>> + ;;
>> +esac
>> +
> What about adding (most of) this to sh.config by the configure script?
> I'd like to centralize all hacky platform detection there.
Do you mean something like this? - Checking $platform and
conditionally adding shopt and aliases. But one must be sure that
every script that source sh.config is a bash script.
diff --git a/configure b/configure
index 72db26df..ef6f657f 100755
--- a/configure
+++ b/configure
@@ -1205,6 +1205,23 @@ NOTMUCH_PYTHON=${python}
NOTMUCH_HAVE_RUBY_DEV=${have_ruby_dev}
EOF
+# Alias native BSD utilities to usable GNU equivalents.
+if [ $platform == FREEBSD ]; then
+ cat >> sh.config <<EOF
+
+# Allow using aliases in bash test scripts
+shopt -s expand_aliases
+
+# Substitute BSD utils with GNU ones (sysutils/coreutils required)
+alias date=gdate
+alias base64=gbase64
+alias gdb=\$BSD_GDB
+alias wc=gwc
+alias sed=gsed
+alias sha256sum=gsha256sum
+EOF
+fi
+
# Finally, after everything configured, inform the user how to continue.
cat <<EOF
> Also, why is gsed in quotes but none of the others are?
Fixed, thanks.
next prev parent reply other threads:[~2016-12-21 14:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 19:47 [PATCH] tests: add compatibility layer mp39590
2016-12-20 22:24 ` David Bremner
2016-12-21 5:12 ` Tomi Ollila
2016-12-21 14:56 ` Mikhail [this message]
2016-12-22 9:31 ` mp39590
2016-12-31 11:03 ` David Bremner
2017-01-02 13:57 ` mp39590
2017-01-03 15:48 ` Tomi Ollila
2017-01-03 15:52 ` Tomi Ollila
2017-01-03 17:21 ` Tomi Ollila
2017-01-04 1:57 ` Mikhail
2016-12-31 15:17 ` Tomi Ollila
-- strict thread matches above, loose matches on Subject: below --
2017-03-09 13:32 David Bremner
2017-03-09 15:47 ` Tomi Ollila
2017-03-24 20:33 ` Mikhail
2017-03-25 11:10 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59549208.20161221175627@gmail.com \
--to=mp39590@gmail.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).