[PATCH] VIM: Automatically refresh folder screen

[PATCH] VIM: Automatically refresh folder screen

[Ian Main]

This patch makes the folder screen refresh each time you 'enter' it.
This way when you read a folder and mark items as read the changes are
reflected immediately when you return to the folder view.

    Ian
---
 vim/notmuch.vim | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/vim/notmuch.vim b/vim/notmuch.vim
index 331e930..eb17d57 100644
--- a/vim/notmuch.vim
+++ b/vim/notmuch.vim
@@ -383,6 +383,9 @@ function! s:folders()
 	ruby folders_render()
 	call s:set_menu_buffer()
 	call s:set_map(g:notmuch_folders_maps)
+	autocmd BufEnter,WinEnter,BufWinEnter <buffer>
+		    \ call s:folders_refresh()
+	augroup END
 endfunction
 
 "" root
-- 
1.9.3

RE: [PATCH] VIM: Automatically refresh folder screen

[Bartosz Telenczuk]

Ian Main wrote:
> This patch makes the folder screen refresh each time you 'enter' it.
> This way when you read a folder and mark items as read the changes are
> reflected immediately when you return to the folder view.

That is a good starting point, but why don't we refresh every time we mark an item in the folder screen?

Bartosz

RE: [PATCH] VIM: Automatically refresh folder screen

[Franz Fellner]

Hi Bartosz,

Great to see one more person interested in notmuch-vim! Hopefully this will make review a little bit easier.

Bartosz Telenczuk wrote:
> Ian Main wrote:
> > This patch makes the folder screen refresh each time you 'enter' it.
> > This way when you read a folder and mark items as read the changes are
> > reflected immediately when you return to the folder view.
> 
> That is a good starting point, but why don't we refresh every time we mark an item in the folder screen?

Personally I don't see the benefit. It's a useless call to notmuch for every cursor-move. Especially with the current inefficient implementation.
Pressing '=' will refresh the folder view manually. If you want to get notified about new mail it's better to call e.g. notify-send after notmuch new.
Automatic refresh after you finished reading your new mails and come back to folders IMHO makes sense.

But probably Ian has a different oppinion.

Franz

> 
> Bartosz
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

RE: [PATCH] VIM: Automatically refresh folder screen

[Bartosz Telenczuk]

Franz Fellner wrote:
> Hi Bartosz,
> 
> Great to see one more person interested in notmuch-vim! Hopefully this will make review a little bit easier.
> 
> Bartosz Telenczuk wrote:
> > Ian Main wrote:
> > > This patch makes the folder screen refresh each time you 'enter' it.
> > > This way when you read a folder and mark items as read the changes are
> > > reflected immediately when you return to the folder view.
> > 
> > That is a good starting point, but why don't we refresh every time we mark an item in the folder screen?
> 
> Personally I don't see the benefit. It's a useless call to notmuch for every cursor-move. Especially with the current inefficient implementation.

I meant that we should refresh after one tags a thread (for example archive it with "A" key). It is slightly annoying that the messages do not disappear after being archived. In my version of the plugin it also causes a wrong thread to be opened when I enter it.

Anyway, this is a small incremental change that can be implemented later.. It should not hold back the patch. These patches are already great and should accepted as soon as possible, so we can move forward and synchronize notmuch-repo with Ian's repo and possibly catch up with emacs (sic!) client.

Cheers,

Bartosz

[PATCH] VIM: Automatically refresh folder screen

[Ian Main]

This patch makes the folder screen refresh each time you 'enter' it.
This way when you read a folder and mark items as read the changes are
reflected immediately when you return to the folder view.

    Ian
---
 vim/notmuch.vim | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/vim/notmuch.vim b/vim/notmuch.vim
index 331e930..eb17d57 100644
--- a/vim/notmuch.vim
+++ b/vim/notmuch.vim
@@ -383,6 +383,9 @@ function! s:folders()
 	ruby folders_render()
 	call s:set_menu_buffer()
 	call s:set_map(g:notmuch_folders_maps)
+	autocmd BufEnter,WinEnter,BufWinEnter <buffer>
+		    \ call s:folders_refresh()
+	augroup END
 endfunction
 
 "" root
-- 
1.9.3

RE: [PATCH] VIM: Automatically refresh folder screen

[Ian Main]

Can I get someone to test this one?  It's pretty simple and useful.

    Ian

Ian Main wrote:
> This patch makes the folder screen refresh each time you 'enter' it.
> This way when you read a folder and mark items as read the changes are
> reflected immediately when you return to the folder view.
> 
>     Ian
> ---
>  vim/notmuch.vim | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/vim/notmuch.vim b/vim/notmuch.vim
> index 331e930..eb17d57 100644
> --- a/vim/notmuch.vim
> +++ b/vim/notmuch.vim
> @@ -383,6 +383,9 @@ function! s:folders()
>  	ruby folders_render()
>  	call s:set_menu_buffer()
>  	call s:set_map(g:notmuch_folders_maps)
> +	autocmd BufEnter,WinEnter,BufWinEnter <buffer>
> +		    \ call s:folders_refresh()
> +	augroup END
>  endfunction
>  
>  "" root
> -- 
> 1.9.3
> 

Re: [PATCH] VIM: Automatically refresh folder screen

[David Bremner]

Ian Main <imain@stemwinder.org> writes:

> This patch makes the folder screen refresh each time you 'enter' it.
> This way when you read a folder and mark items as read the changes are
> reflected immediately when you return to the folder view.

It seems to work, but it is pretty slow for large mailboxes. I have
270000 unread messages and there is a pause of about 1 second when
returning to the "folder screen".  I'm not sure, maybe the vim interface
is just overall not usable with such large search results?

Re: [PATCH] VIM: Automatically refresh folder screen

[Franz Fellner]

David Bremner wrote:
> Ian Main <imain@stemwinder.org> writes:
> 
> > This patch makes the folder screen refresh each time you 'enter' it.
> > This way when you read a folder and mark items as read the changes are
> > reflected immediately when you return to the folder view.
> 
> It seems to work, but it is pretty slow for large mailboxes. I have
> 270000 unread messages and there is a pause of about 1 second when
> returning to the "folder screen".  I'm not sure, maybe the vim interface
> is just overall not usable with such large search results?

I remember the times (not that far away) when paging through the result of a query
in the emacs interface resulted in a lock of several seconds after each <PGDOWN> or
<DOWN> keypress, even in medium sized queries of 1000 queries. This went away in the
meantime.

I just found the issue that caused the lag in the vim interface:
https://github.com/imain/notmuch-vim/commit/649c18122befbabb52082b7d7f77abf863efc62b

Using query.count_messages instead of query.search_messages.count did the trick.

> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch