unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Bartosz Telenczuk <telenczuk@unic.cnrs-gif.fr>
To: Ian Main <imain@stemwinder.org>,  notmuch@notmuchmail.org
Subject: RE: [PATCH v3] VIM: Improve moving between messages in a thread
Date: Tue, 13 Jan 2015 00:47:19 +0100	[thread overview]
Message-ID: <54b45d071fd20_7f93fe5bd4401f087@bts-MacBook-Pro.local.notmuch> (raw)
In-Reply-To: <1413828111-2879-1-git-send-email-imain@stemwinder.org>

Hi Ian,

The patch looks good. I tested it on my system and it works fine.  I just have one suggestion regarding coding style.

> +function! s:show_prev_msg()
>  function! s:show_next_msg()

Since these functions are almost the same, you could avoid code repetition by replacing them by a function which takes (positive or negative) increment as an argument.

Cheers,

Bartosz

  reply	other threads:[~2015-01-12 23:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-06  7:12 [PATCH] Improve moving between messages in a thread Ian Main
2014-10-06 17:25 ` Ian Main
2014-10-06 17:55 ` [PATCH] VIM: " Ian Main
2014-10-10  9:21   ` Franz Fellner
2014-10-10 18:21     ` Ian Main
2014-10-18 20:30       ` Franz Fellner
2014-10-19  9:51         ` Tomi Ollila
2014-10-20 18:01   ` [PATCH v3] " Ian Main
2015-01-12 23:47     ` Bartosz Telenczuk [this message]
2015-01-21 18:53       ` Franz Fellner
2015-02-02 23:44         ` Bartosz Telenczuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54b45d071fd20_7f93fe5bd4401f087@bts-MacBook-Pro.local.notmuch \
    --to=telenczuk@unic.cnrs-gif.fr \
    --cc=imain@stemwinder.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).