From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id EF701431FC9 for ; Fri, 24 Oct 2014 10:04:04 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WwImhjIcC5Rl for ; Fri, 24 Oct 2014 10:03:57 -0700 (PDT) Received: from cmta15.telus.net (cmta15.telus.net [209.171.16.88]) by olra.theworths.org (Postfix) with ESMTP id 5BD11431FBD for ; Fri, 24 Oct 2014 10:03:57 -0700 (PDT) Received: from ovo.mains.priv ([207.102.88.62]) by cmta15.telus.net with TELUS id 753w1p0031LiWEf0153wLd; Fri, 24 Oct 2014 11:03:57 -0600 X-Authority-Analysis: v=2.0 cv=ZZnDwLpA c=1 sm=2 a=EcQDfIwDZEqJA1f7rVUV8Q==:17 a=IkcTkHD0fZMA:10 a=tsa3CZZnAAAA:8 a=4XS9hI5N2F8fzkbNu8cA:9 a=QEXdDO2ut3YA:10 a=EcQDfIwDZEqJA1f7rVUV8Q==:117 X-Telus-Outbound-IP: 207.102.88.62 Received: from ovo.mains.priv (localhost.localdomain [127.0.0.1]) by ovo.mains.priv (8.14.8/8.14.8) with ESMTP id s9OH3rOG004193; Fri, 24 Oct 2014 10:03:54 -0700 Received: (from imain@localhost) by ovo.mains.priv (8.14.8/8.14.8/Submit) id s9OH3qCL004192; Fri, 24 Oct 2014 10:03:52 -0700 X-Authentication-Warning: ovo.mains.priv: imain set sender to imain@redhat.com using -f Date: Fri, 24 Oct 2014 10:03:52 -0700 From: Ian Main To: Tomi Ollila , Tomi Ollila , notmuch@notmuchmail.org Message-ID: <544a8678c3deb_bdfbf9e886a@ovo.mains.priv.notmuch> In-Reply-To: References: <1414102794-12094-1-git-send-email-imain@stemwinder.org> <1414167094-31566-1-git-send-email-imain@stemwinder.org> Subject: Re: [PATCH v3] VIM: Add URI handling Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Oct 2014 17:04:05 -0000 Tomi Ollila wrote: > On Fri, Oct 24 2014, Ian Main wrote: > > This patch does not apply on top of notmuchmail master > (commit 38240d106139da8). > > > This patch adds URI handling to the vim client. You can now press > > Although insignificant, I'll start commenting on all sent patches > (that I look into) which talk like 'This patch adds' -- sure it is patch > when email is sent, but in repository it is not so -- so the commit message > should not mention it (but I do not require changing it). > > Anyway, I suspect this change will become applicable after some other > change is committed first -- and IMO this could stay as non-stale patch > provided that SomeOne(TM) informs what is the message that contains > changes (or series those) that is required for this message to apply. > > BTW: does the content of this change differ much from v1 at > id:1412281423-22441-1-git-send-email-imain@stemwinder.org > or should I re-check (carefully!) that the changes are still OK. > > > Tomi > This one is almost identical minus the hotkey usage. The attachment support patch has changed a fair bit in that it now looks at all parts of multipart messages, giving you the opportunity to view the original text/html message in a web browser. I sent them out as a series in a new thread so that it would be easier to follow. I have them all applied locally and there were some conflicts to resolve. They are simple, usually around the defaults settings for the configuration but it's still a pain. I'm still tempted to send out all of the outstanding patches as a big series. All the patches posted though should apply to master so I may just have to rebase now and again. Ian