unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Ian Main <imain@stemwinder.org>
To: Tomi Ollila <tomi.ollila@iki.fi>,
	Tomi Ollila <tomi.ollila@iki.fi>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH v3] VIM: Add URI handling
Date: Fri, 24 Oct 2014 10:03:52 -0700	[thread overview]
Message-ID: <544a8678c3deb_bdfbf9e886a@ovo.mains.priv.notmuch> (raw)
In-Reply-To: <m2oat177mi.fsf@guru.guru-group.fi>

Tomi Ollila wrote:
> On Fri, Oct 24 2014, Ian Main <imain@stemwinder.org> wrote:
> 
> This patch does not apply on top of notmuchmail master 
> (commit 38240d106139da8).
> 
> > This patch adds URI handling to the vim client.  You can now press
> 
> Although insignificant, I'll start commenting on all sent patches
> (that I look into) which talk like 'This patch adds' -- sure it is patch
> when email is sent, but in repository it is not so -- so the commit message
> should not mention it (but I do not require changing it).
> 
> Anyway, I suspect this change will become applicable after some other
> change is committed first -- and IMO this could stay as non-stale patch
> provided that SomeOne(TM) informs what is the message that contains
> changes (or series those) that is required for this message to apply.
> 
> BTW: does the content of this change differ much from v1 at
> id:1412281423-22441-1-git-send-email-imain@stemwinder.org
> or should I re-check (carefully!) that the changes are still OK.
> 
> 
> Tomi
> 

This one is almost identical minus the hotkey usage.  The attachment support
patch has changed a fair bit in that it now looks at all parts of multipart
messages, giving you the opportunity to view the original text/html message
in a web browser.

I sent them out as a series in a new thread so that it would be easier to
follow.  I have them all applied locally and there were some conflicts to
resolve.  They are simple, usually around the defaults settings for the
configuration but it's still a pain.  I'm still tempted to send out all
of the outstanding patches as a big series.  All the patches posted though
should apply to master so I may just have to rebase now and again.

    Ian

      reply	other threads:[~2014-10-24 17:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 20:23 [PATCH] VIM: Add URI handling Ian Main
2014-10-10  9:44 ` Franz Fellner
2014-10-10 18:18   ` Ian Main
2014-10-11 12:29     ` Franz Fellner
2014-10-15 19:33       ` Ian Main
2014-10-17 16:14         ` Franz Fellner
2014-10-20 17:45           ` Ian Main
2014-10-20 19:05           ` Tomi Ollila
2014-10-20 19:38             ` Franz Fellner
2014-10-21 14:25               ` Tomi Ollila
2014-10-20 18:53 ` Tomi Ollila
2014-10-23 22:19 ` [PATCH v2] " Ian Main
2014-10-24  9:52   ` Tomi Ollila
2014-10-24 16:11   ` [PATCH v3] " Ian Main
2014-10-24 16:30     ` Tomi Ollila
2014-10-24 17:03       ` Ian Main [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=544a8678c3deb_bdfbf9e886a@ovo.mains.priv.notmuch \
    --to=imain@stemwinder.org \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).