From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 55FB4431FC7 for ; Sun, 25 May 2014 08:58:42 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UQoH3eSUQrp8 for ; Sun, 25 May 2014 08:58:36 -0700 (PDT) Received: from mail-ob0-f176.google.com (mail-ob0-f176.google.com [209.85.214.176]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id D4671431FAF for ; Sun, 25 May 2014 08:58:36 -0700 (PDT) Received: by mail-ob0-f176.google.com with SMTP id wo20so7099848obc.7 for ; Sun, 25 May 2014 08:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-type:content-transfer-encoding; bh=1Do0/u9B6LQLdJAB9z+8nk2mFGwu88HksB4s4BJj8yo=; b=NmFLG71/TB8ErTDmmNE1qir410Rl1+0th78zyJSO/d+gVHQPBFaP5qmBfVNe6ak2d2 8/JSqGbAHWwG4mK5QEt1tLJUWRckEf8nfs9erqZITF92BorbccGRkCQ1i32CvznDhxRl NcIeNTWzl2ONCE7Cg48eKiQIN16VzVNnYy5r6Zc4p+11pYRpxctcUIDGSb4o2DbNS2+D xz6PuVhoMR1G9ir06BdEHyOrLFww+QOtRSt42G/3By8uXfk2ypvwbqnPa75PoHtvIifi ws7nhF2ZtTf/kYZ/CHq5cHcV4JesgU3dQ4H2fzhy3t6/wAkCH7kasuAsHE92BiLEZYGX p/iQ== X-Received: by 10.182.58.83 with SMTP id o19mr19404289obq.26.1401033514459; Sun, 25 May 2014 08:58:34 -0700 (PDT) Received: from localhost (189-211-224-40.static.axtel.net. [189.211.224.40]) by mx.google.com with ESMTPSA id fj9sm33592555oeb.6.2014.05.25.08.58.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 May 2014 08:58:33 -0700 (PDT) Date: Sun, 25 May 2014 10:47:10 -0500 From: Felipe Contreras To: Jani Nikula , Felipe Contreras , Felipe Contreras , notmuch@notmuchmail.org Message-ID: <5382107e7870f_2275ff3304ec@nysa.notmuch> In-Reply-To: <87r43ii5dx.fsf@nikula.org> References: <1400841267-12807-1-git-send-email-felipe.contreras@gmail.com> <1400841267-12807-2-git-send-email-felipe.contreras@gmail.com> <87wqdai92o.fsf@nikula.org> <5381a172d52b5_d72bf52fc50@nysa.notmuch> <87r43ii5dx.fsf@nikula.org> Subject: Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Ali Polatel X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 May 2014 15:58:42 -0000 Jani Nikula wrote: > On Sun, 25 May 2014, Felipe Contreras wrote: > > Jani Nikula wrote: > >> On Fri, 23 May 2014, Felipe Contreras wrote: > >> > They don't affect the global build. > >> > >> They do. > > > > They don't. > > Your patch, your commit message, please explain *why* you think they > wouldn't or shouldn't affect the global build. Just to mention one > thing, why someone modifying cflags in sub makefiles shouldn't cause > rebuild? Go to emacs/Makefile, it's basically a stub, why would any modifications there affect the global build? It's not included anywhere. emacs/Makefile.local is included in the global build, emacs/Makefile is not. -- Felipe Contreras