From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jani Nikula <jani@nikula.org>,
Felipe Contreras <felipe.contreras@gmail.com>,
Felipe Contreras <felipe.contreras@gmail.com>,
notmuch@notmuchmail.org
Cc: Ali Polatel <alip@exherbo.org>
Subject: Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps
Date: Sun, 25 May 2014 10:47:10 -0500 [thread overview]
Message-ID: <5382107e7870f_2275ff3304ec@nysa.notmuch> (raw)
In-Reply-To: <87r43ii5dx.fsf@nikula.org>
Jani Nikula wrote:
> On Sun, 25 May 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:
> > Jani Nikula wrote:
> >> On Fri, 23 May 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:
> >> > They don't affect the global build.
> >>
> >> They do.
> >
> > They don't.
>
> Your patch, your commit message, please explain *why* you think they
> wouldn't or shouldn't affect the global build. Just to mention one
> thing, why someone modifying cflags in sub makefiles shouldn't cause
> rebuild?
Go to emacs/Makefile, it's basically a stub, why would any modifications
there affect the global build? It's not included anywhere.
emacs/Makefile.local is included in the global build, emacs/Makefile is
not.
--
Felipe Contreras
next prev parent reply other threads:[~2014-05-25 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 10:34 [PATCH 0/3] Build and test Ruby bindings Felipe Contreras
2014-05-23 10:34 ` [PATCH 1/3] build: don't add sub Makefiles to the global deps Felipe Contreras
2014-05-25 7:58 ` Jani Nikula
2014-05-25 7:53 ` Felipe Contreras
2014-05-25 9:17 ` Jani Nikula
2014-05-25 15:47 ` Felipe Contreras [this message]
2014-05-25 17:01 ` Jani Nikula
2014-05-23 10:34 ` [PATCH 2/3] build: add support to build Ruby bindings Felipe Contreras
2014-05-23 15:04 ` Wael Nasreddine
2014-07-13 14:28 ` David Bremner
2014-05-23 10:34 ` [PATCH 3/3] test: add tests for " Felipe Contreras
2014-07-13 13:11 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5382107e7870f_2275ff3304ec@nysa.notmuch \
--to=felipe.contreras@gmail.com \
--cc=alip@exherbo.org \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).