[PATCH] ruby: Add wrapper for notmuch_query_count_threads

[PATCH] ruby: Add wrapper for notmuch_query_count_threads

[Wael M. Nasreddine]

This patch exposes query.cc::notmuch_query_count_threads to Ruby, the
benchmark on 85k emails is amazing:

                                user     system      total        real
query.count_threads         6.270000   0.240000   6.510000 (  6.507064)
query.search_threads.count 14.040000   3.130000  17.170000 ( 17.172222)

[PATCH] ruby: Add wrapper for notmuch_query_count_threads

[Wael M. Nasreddine]

---
 bindings/ruby/defs.h  |  3 +++
 bindings/ruby/init.c  |  1 +
 bindings/ruby/query.c | 19 +++++++++++++++++++
 3 files changed, 23 insertions(+)

diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h
index 5b44585..f4901a0 100644
--- a/bindings/ruby/defs.h
+++ b/bindings/ruby/defs.h
@@ -231,6 +231,9 @@ notmuch_rb_query_search_messages (VALUE self);
 VALUE
 notmuch_rb_query_count_messages (VALUE self);
 
+VALUE
+notmuch_rb_query_count_threads (VALUE self);
+
 /* threads.c */
 VALUE
 notmuch_rb_threads_destroy (VALUE self);
diff --git a/bindings/ruby/init.c b/bindings/ruby/init.c
index 663271d..ab3f22d 100644
--- a/bindings/ruby/init.c
+++ b/bindings/ruby/init.c
@@ -271,6 +271,7 @@ Init_notmuch (void)
     rb_define_method (notmuch_rb_cQuery, "search_threads", notmuch_rb_query_search_threads, 0); /* in query.c */
     rb_define_method (notmuch_rb_cQuery, "search_messages", notmuch_rb_query_search_messages, 0); /* in query.c */
     rb_define_method (notmuch_rb_cQuery, "count_messages", notmuch_rb_query_count_messages, 0); /* in query.c */
+    rb_define_method (notmuch_rb_cQuery, "count_threads", notmuch_rb_query_count_threads, 0); /* in query.c */
 
     /*
      * Document-class: Notmuch::Threads
diff --git a/bindings/ruby/query.c b/bindings/ruby/query.c
index 1658ede..a7dacba 100644
--- a/bindings/ruby/query.c
+++ b/bindings/ruby/query.c
@@ -182,3 +182,22 @@ notmuch_rb_query_count_messages (VALUE self)
      */
     return UINT2NUM(notmuch_query_count_messages(query));
 }
+
+/*
+ * call-seq: QUERY.count_threads => Fixnum
+ *
+ * Return an estimate of the number of threads matching a search
+ */
+VALUE
+notmuch_rb_query_count_threads (VALUE self)
+{
+    notmuch_query_t *query;
+
+    Data_Get_Notmuch_Query (self, query);
+
+    /* Xapian exceptions are not handled properly.
+     * (function may return 0 after printing a message)
+     * Thus there is nothing we can do here...
+     */
+    return UINT2NUM(notmuch_query_count_threads(query));
+}
-- 
1.9.1.423.g4596e3a

RE: [PATCH] ruby: Add wrapper for notmuch_query_count_threads

[Felipe Contreras]

Wael M. Nasreddine wrote:
> ---
>  bindings/ruby/defs.h  |  3 +++
>  bindings/ruby/init.c  |  1 +
>  bindings/ruby/query.c | 19 +++++++++++++++++++
>  3 files changed, 23 insertions(+)

LGTM.

-- 
Felipe Contreras

Re: [PATCH] ruby: Add wrapper for notmuch_query_count_threads

[David Bremner]

"Wael M. Nasreddine" <wael.nasreddine@gmail.com> writes:

> ---
>  bindings/ruby/defs.h  |  3 +++
>  bindings/ruby/init.c  |  1 +
>  bindings/ruby/query.c | 19 +++++++++++++++++++
>  3 files changed, 23 insertions(+)

pushed.  FYI in general we like commit messages a bit more verbose,
although I have to admit I don't what to add here.

d

RE: [PATCH] ruby: Add wrapper for notmuch_query_count_threads

[Felipe Contreras]

Wael M. Nasreddine wrote:
> This patch exposes query.cc::notmuch_query_count_threads to Ruby, the
> benchmark on 85k emails is amazing:

I meant to do this but forgot. Thanks!

-- 
Felipe Contreras