From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Tomi Ollila" <tomi.ollila@iki.fi>,
"Felipe Contreras" <felipe.contreras@gmail.com>,
Xīcò <xico@atelo.org>,
notmuch@notmuchmail.org
Subject: RE: [PATCH 1/2] configure: add a fallback check for zlib
Date: Sat, 10 May 2014 17:27:34 -0500 [thread overview]
Message-ID: <536ea7d6a4c86_3c5a8eb3048b@nysa.notmuch> (raw)
In-Reply-To: <m261ldi98h.fsf@guru.guru-group.fi>
Tomi Ollila wrote:
> On Sun, May 11 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:
>
> > Xīcò wrote:
> >> Since zlib is part of the base system, FreeBSD chose not to register it
> >> in pkg-config through zlib.pc. As a fallback test, configure will build
> >> and run a zlib version check and make sure the header and library
> >> versions are compatible.
> >
> > We could try to generate our on zlib.pc, this way the configure script
> > would be cleaner.
>
> But for that we'd need to figure out the version, and is there simpler
> robust way to do that some other way ?
I don't meant to change the code that is checking for the version in the
patch, you use the same code, but instead of have_zlib.c gen_zlib_pc.c,
or something.
--
Felipe Contreras
next prev parent reply other threads:[~2014-05-10 22:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-10 20:27 [PATCH 1/2] configure: add a fallback check for zlib Xīcò
2014-05-10 21:13 ` Felipe Contreras
2014-05-10 22:01 ` Tomi Ollila
2014-05-10 22:27 ` Felipe Contreras [this message]
2014-05-21 9:13 ` Fraser Tweedale
2014-05-21 19:34 ` Tomi Ollila
2014-05-21 22:13 ` Fraser Tweedale
2014-05-22 8:15 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536ea7d6a4c86_3c5a8eb3048b@nysa.notmuch \
--to=felipe.contreras@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
--cc=xico@atelo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).