From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 042D7431FD0 for ; Sat, 2 Nov 2013 06:30:42 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UpwdobaVDb35 for ; Sat, 2 Nov 2013 06:30:35 -0700 (PDT) Received: from mail-oa0-f48.google.com (mail-oa0-f48.google.com [209.85.219.48]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id CB7B9431FC4 for ; Sat, 2 Nov 2013 06:30:34 -0700 (PDT) Received: by mail-oa0-f48.google.com with SMTP id m17so5641428oag.35 for ; Sat, 02 Nov 2013 06:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:message-id:in-reply-to:references:subject:mime-version :content-type:content-transfer-encoding; bh=hSXJ1J5D2hcegq6agPhZIHMoANkgwMMtXmDEEx5x+Gc=; b=IV4SxC0GZBqtNORhwU7rbYENigGbW5cH5tiiUkTWA+qP8x6ZdwY9H/Rgf9odIWfdFy Efikd9MhNpu5fWrsR0VwjiMQxYcWkQHlqfTAl1JKdB0bUD/tBUlhZQFVkjYgW68PhWgZ 2wcd1U8oM+Y4AbsNTJqRvoFz+QmA7PbsnthSc5wrBH6mXw7L1+pN86f7/SS8/u3/OyzT 10XDdwGTJFHt7m2Ia676yDb9NG8mper3XmtqEqSVoCFCOP3xiv1pPdjIA0akxkNKZ/yC 73PJqPRkGEbBoogLW+jQwwp1/PazDF6+iMAdywAEddAonSMLL90AXc+jh/K0iwLKaiHH 07EA== X-Received: by 10.60.40.136 with SMTP id x8mr1304814oek.49.1383399034218; Sat, 02 Nov 2013 06:30:34 -0700 (PDT) Received: from localhost (187-162-140-241.static.axtel.net. [187.162.140.241]) by mx.google.com with ESMTPSA id z5sm19780341obg.13.2013.11.02.06.30.32 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Nov 2013 06:30:33 -0700 (PDT) Date: Sat, 02 Nov 2013 07:22:39 -0600 From: Felipe Contreras To: David Bremner , Felipe Contreras , Felipe Contreras , notmuch@notmuchmail.org Message-ID: <5274fc9ef3925_6f56937e844a@nysa.notmuch> In-Reply-To: <87d2mjrlh3.fsf@zancas.localnet> References: <1380558523-6913-1-git-send-email-felipe.contreras@gmail.com> <87txgpv16s.fsf@zancas.localnet> <5274ed4d5126a_46fcefbe747f@nysa.notmuch> <87d2mjrlh3.fsf@zancas.localnet> Subject: Re: [PATCH 0/3] General fixes Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Nov 2013 13:30:43 -0000 David Bremner wrote: > Felipe Contreras writes: > > > David Bremner wrote: > >> Felipe Contreras writes: > >> > >> > Felipe Contreras (3): > >> > query: bind queries to database objects > >> > ruby: allow build with RUNPATH > >> > ruby: bind database close()/destroy() properly > >> > >> I agree with the discussion on IRC that the change in the first patch > >> makes sense. > > > > Shall I push it to the master branch then? > > sure. Done. > > I don't really care that much about patch #2, but #3 should probably be > > applied. > > Just to be clear, I wasn't objecting to patch 2, just asking for a few > more words of commit message. Yes, that's what I understood, but at the moment I don't thin it's worth my time to do that. There's mor interesting stuff to do, maybe later. > For patch 3, since it's ruby specific and > nobody complained, I'd say go for it. All right. I'll probably wait a bit more, maybe a week to see if somebody shouts. -- Felipe Contreras