unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: David Bremner <david@tethera.net>,
	 Felipe Contreras <felipe.contreras@gmail.com>,
	 Felipe Contreras <felipe.contreras@gmail.com>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH 0/3] General fixes
Date: Sat, 02 Nov 2013 07:22:39 -0600	[thread overview]
Message-ID: <5274fc9ef3925_6f56937e844a@nysa.notmuch> (raw)
In-Reply-To: <87d2mjrlh3.fsf@zancas.localnet>

David Bremner wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
> > David Bremner wrote:
> >> Felipe Contreras <felipe.contreras@gmail.com> writes:
> >> 
> >> > Felipe Contreras (3):
> >> >   query: bind queries to database objects
> >> >   ruby: allow build with RUNPATH
> >> >   ruby: bind database close()/destroy() properly
> >> 
> >> I agree with the discussion on IRC that the change in the first patch
> >> makes sense.
> >
> > Shall I push it to the master branch then?
> 
> sure.

Done.

> > I don't really care that much about patch #2, but #3 should probably be
> > applied.
> 
> Just to be clear, I wasn't objecting to patch 2, just asking for a few
> more words of commit message.

Yes, that's what I understood, but at the moment I don't thin it's worth my
time to do that. There's mor interesting stuff to do, maybe later.

> For patch 3, since it's ruby specific and
> nobody complained, I'd say go for it.

All right. I'll probably wait a bit more, maybe a week to see if somebody
shouts.

-- 
Felipe Contreras

  reply	other threads:[~2013-11-02 13:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30 16:28 [PATCH 0/3] General fixes Felipe Contreras
2013-09-30 16:28 ` [PATCH 1/3] query: bind queries to database objects Felipe Contreras
2013-09-30 16:28 ` [PATCH 2/3] ruby: allow build with RUNPATH Felipe Contreras
2013-09-30 16:28 ` [PATCH 3/3] ruby: bind database close()/destroy() properly Felipe Contreras
2013-10-10 11:02 ` [PATCH 0/3] General fixes David Bremner
2013-10-15  5:25   ` Felipe Contreras
2013-11-02 12:17   ` Felipe Contreras
2013-11-02 13:18     ` David Bremner
2013-11-02 13:22       ` Felipe Contreras [this message]
2013-11-02 13:39         ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5274fc9ef3925_6f56937e844a@nysa.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).