From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 71AC2431FD0 for ; Mon, 19 Sep 2011 11:16:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k96+3J6OfAaG for ; Mon, 19 Sep 2011 11:16:15 -0700 (PDT) Received: from mail-ew0-f51.google.com (mail-ew0-f51.google.com [209.85.215.51]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id ABCEA431FB6 for ; Mon, 19 Sep 2011 11:16:15 -0700 (PDT) Received: by ewy5 with SMTP id 5so1199975ewy.38 for ; Mon, 19 Sep 2011 11:16:14 -0700 (PDT) Received: by 10.52.21.3 with SMTP id r3mr2375612vde.437.1316456173925; Mon, 19 Sep 2011 11:16:13 -0700 (PDT) Received: from localhost (r74-193-78-30.pfvlcmta01.grtntx.tl.dh.suddenlink.net. [74.193.78.30]) by mx.google.com with ESMTPS id ch2sm15568795vdc.19.2011.09.19.11.16.09 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 19 Sep 2011 11:16:10 -0700 (PDT) Message-ID: <4e7786ea.62b0340a.101a.ffffd05f@mx.google.com> From: Ryan Harper Subject: Re: [PATCH 0/2] vim plugin: implement viewing/saving attachments To: Blake Sweeney , notmuch@notmuchmail.org In-Reply-To: <4e768a72.2888ec0a.1eb5.29f3@mx.google.com> References: <1316226470-30001-1-git-send-email-rharper@shake.ath.cx> <4e768a72.2888ec0a.1eb5.29f3@mx.google.com> Date: Mon, 19 Sep 2011 13:15:32 -0500 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2011 18:16:16 -0000 On Sun, 18 Sep 2011 20:18:56 -0400, Blake Sweeney wrote: > On Fri, 16 Sep 2011 21:27:48 -0500, Ryan Harper wrote: > > I've just started using notmuch and the vim plugin. I'm almost ready to ditch > > my mutt config, but I really needed attachment viewing/saving. > > > > I've got something functional, but I've never hacked on vimscript before so > > looking for feedback on how to clean up the patches. > > > > > > Ryan --- Give a man a beer, he'll drink for the day. Teach a man to brew, > > he'll be drunk the rest of his life. > > > > In the second patch you have a typo, the function is called > NM_show_save_mime_part in the config but should be called > NM_show_save_mime_parts. Other than that, I tried it and like it. Blake, thanks for testing and catching that. I did the patches out of repository and was transplanting back to the git repo. I'll fixup and resubmit. Ryan -- Give a man a beer, he'll drink for the day. Teach a man to brew, he'll be drunk the rest of his life.