From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 74DE2431FC4 for ; Sun, 22 Nov 2009 08:00:38 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0NtT+XqUk2AL for ; Sun, 22 Nov 2009 08:00:36 -0800 (PST) Received: from aegir.org.uk (aegir.org.uk [87.238.170.13]) by olra.theworths.org (Postfix) with ESMTP id 6DA8F431FC0 for ; Sun, 22 Nov 2009 08:00:36 -0800 (PST) Received: from localhost.localdomain (109-9-ftth.onsnetstudenten.nl [145.120.9.109]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by aegir.org.uk (Postfix) with ESMTPSA id E43BE2E03C; Sun, 22 Nov 2009 17:00:35 +0100 (CET) Date: Sun, 22 Nov 2009 17:00:36 +0100 From: Michiel Buddingh' To: djcb@djcbsoftware.nl Message-ID: <4b096024.f5WEZqYlMxgYs/o1%michiel@michielbuddingh.net> References: <87fx8bygi7.fsf@linux.vnet.ibm.com> <87bpiv4t9h.fsf@yoom.home.cworth.org> <87y6lz39nd.fsf@yoom.home.cworth.org> <20091121221207.GB17268@jukie.net> <9cce5525b093b87fe74d427954ffad89@localhost> <87d43b2oif.fsf@yoom.home.cworth.org> <9bfdedddeab9c58cd45d8d448323d0fc@localhost> <87vdh2n7y2.wl%djcb@djcbsoftware.nl> In-Reply-To: <87vdh2n7y2.wl%djcb@djcbsoftware.nl> User-Agent: Heirloom mailx 12.4 7/29/08 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: notmuch@notmuchmail.org Subject: Re: [PATCH] notmuch: Add Maildir directory name as tag name for messages X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Nov 2009 16:00:38 -0000 Dirk-Jan C. Binnema wrote: > Michiel> + > Michiel> +static void > Michiel> +derive_tags_from_maildir_flags (notmuch_message_t > Michiel> *message, const char * > Michiel> path) > > I see you don't handle the "N" -- is that deliberate? Also, a > minor addition may to also allow for '!' instead of ':' as a > separator, as that's the semi-official way to use Maildirs on > (V)FAT filesystems (which don't allow for colons in filenames). Not deliberate. Simply unaware of the "N" flag, nor aware of practices for storing Maildirs on (V)FAT. I've used only this file as a reference. http://cr.yp.to/proto/maildir.html mvg, Michiel Buddingh'