From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B4842431FBC for ; Fri, 27 Jan 2012 10:19:43 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.54 X-Spam-Level: X-Spam-Status: No, score=-0.54 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_BL_SPAMCOP_NET=1.246, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_SORBS_WEB=0.614] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6z0MXmApR69f for ; Fri, 27 Jan 2012 10:19:43 -0800 (PST) Received: from cliffclavin.cs.rpi.edu (cliffclavin.cs.rpi.edu [128.113.126.25]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id F3795431FAE for ; Fri, 27 Jan 2012 10:19:42 -0800 (PST) X-Hash: SCtCte|aa3172f9bebf027dc1fd1da71bbc9c65535d1721|2496b17db9ee623b88d706c775242a92 X-Countries: Cameroon, United States X-SMTP-From: accepted [195.24.209.21] [195.24.209.21] ([10.0.13.172]) {Cameroon} DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=cs.rpi.edu; h= message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=default; i=glasse@cs.rpi.edu; t=1327688376; x=1328293176; l=1165; bh=VUA ICcnNUkSNKWMPCmp7o7v4dxM=; b=kXAVGN6iepKzgPGFQ2+EWsRWIWdmAIgvbAk saeQnnd5/MPagAzi9EFi5rIbemMC2x+VmAaRTVmLn/k4sVet4J6trP8QfqVRp6IK VPqUmo8BAa4c5Qb+fjFDHRlTZy+q7XjAKkwZgIK1W2rQQyqP554oS9dV8Qtd7HHe 39xBtR1U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=cs.rpi.edu; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; q=dns; s=default; b=KIR k5/TAfDi2Uhy2wlscof6WOQWEkk5z0viAL7e1srXgjVoDJeh9PCCmBhFCb81MP6k xsp05pDXSKcLgKJsMOczBxaK+oOH+qQ/8uHFafwBqWt57Ymlbw4EOvDmN132AfzL uT9agG4IMz3p1AFSkF6689hioe6ZOuVWqTjbUReY= X-Spam-Info: -2.7; ALL_TRUSTED,AWL,BAYES_00 X-Spam-Scanned-By: cliffclavin.cs.rpi.edu using SpamAssassin 3.2.5 (hard limit 15) Authentication-Results: cliffclavin.cs.rpi.edu; DKIM=neutral (none) header.from=glasse@cs.rpi.edu; SPF=neutral (mfrom; Mechanism '?all' matched) smtp.mail=glasse@cs.rpi.edu X-Auth-Passed: cliffclavin.cs.rpi.edu:q0RIJ6qf057776 Auth:glasse X-Virus-Scanned-By: cliffclavin.cs.rpi.edu Received: from [10.0.13.172] ([195.24.209.21]) (authenticated bits=0) by cliffclavin.cs.rpi.edu (8.14.3/8.14.3) with ESMTP id q0RIJ6qf057776 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 27 Jan 2012 13:19:31 -0500 (EST) (envelope-from glasse@cs.rpi.edu) Message-ID: <4F22EA91.4020006@cs.rpi.edu> Date: Fri, 27 Jan 2012 13:18:57 -0500 From: Ethan Glasser-Camp User-Agent: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111124 Thunderbird/8.0 MIME-Version: 1.0 To: Tomi Ollila Subject: Re: [PATCH 1/2] moved _notmuch_get_list () and _notmuch_set_list () up in file References: <8762g0sj6f.fsf@praet.org> <1327572718-13411-1-git-send-email-tomi.ollila@iki.fi> <87sjj2ipjh.fsf@nikula.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 128.113.126.25 Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2012 18:19:43 -0000 On 01/27/2012 05:42 AM, Tomi Ollila wrote: > On Thu, 26 Jan 2012 13:03:46 +0000, Jani Nikula wrote: >> On Thu, 26 Jan 2012 12:11:57 +0200, Tomi Ollila wrote: >>> Moved _notmuch_get_list () and _notmuch_set_list () to a location >>> in notmuch-config.c so that new functions that will be located >>> before the old location of those functions can also use these. >> Parse error. ;) >> >> You mean something along the lines of: "Move _notmuch_get_list () and >> _notmuch_set_list () earlier in the file to avoid forward declarations >> in further work. No functional changes." >> >> I'm sure native speakers can bikeshed that further. ;) > Ok, they haven't. I'n resubmit this alone with better commit > message -- I look the other after I have better time. As a native speaker, your new version is acceptable but I found "in further work" a little odd. (Depending on what you meant, I'd say "in upcoming patches".) The thing I found most confusing about the comment is that the functions aren't called _notmuch_get_list or _notmuch_set_list (instead they are _config_get_list and _config_set_list.) Ethan