From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1 with LMTPS id qDkiM1M2il5KIAAAk0OIDg (envelope-from ) for ; Sun, 05 Apr 2020 19:49:39 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cMgsE1I2il4KFgAAB5/wlQ (envelope-from ) for ; Sun, 05 Apr 2020 19:49:38 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id E48ED68434B for ; Sun, 5 Apr 2020 18:42:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id BEAD56DE13DA; Sun, 5 Apr 2020 11:42:03 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bnEqkzIRqE-Q; Sun, 5 Apr 2020 11:42:03 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 065486DE1394; Sun, 5 Apr 2020 11:42:02 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 676DF6DE0F35 for ; Sun, 5 Apr 2020 01:47:27 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6p5p0XkyDpUb for ; Sun, 5 Apr 2020 01:47:26 -0700 (PDT) Received: from mail-40132.protonmail.ch (mail-40132.protonmail.ch [185.70.40.132]) by arlo.cworth.org (Postfix) with ESMTPS id 12A416DE0F1C for ; Sun, 5 Apr 2020 01:47:25 -0700 (PDT) Date: Sun, 05 Apr 2020 08:37:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1586075879; bh=gb48CzbRF08pYs9z1YFxyPaiNC0sTxXSwMJABJJGX9M=; h=Date:To:From:Reply-To:Subject:From; b=AOS0LNVo+6vdZNHqXTwBu+p1RZz5oUtaC4AMK8VIbMeE6EcOtMb6jJO3Y0rVCh3KK PruL3dSw2a5xOnfwmfhGAiPwmM8nwjgp+YCYlPIockt301GHOrd1GZCGAzIyPXAvrC MZPMqCXgc0ZTJ1XUgCLie30BKbcGkHAXBI2qb1KU= To: "notmuch@notmuchmail.org" From: Milton Vandersloot Subject: test_emacs_expect_t does ignore Emacs as prerequisite Message-ID: <4EC8sDKjAVEjYY1U-bmmhcOzj4Sekf_jKwOaaduMv3Oes4rNecwwrOLmvYbFwjGVd_5BW6PEeK7M0iMUKgOkHEwyETf-mjJqFexnKkqSUNM=@protonmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Sun, 05 Apr 2020 11:42:00 -0700 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Milton Vandersloot Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=default; t=1586112126; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=LJEh5O63C4ZDl/YyLuJbleoCdQV78H4iUDXQlwXGyII=; b=fuaw//Q73T+TE4ynJsBUribZJ10Ftdk9/xzrB9g1cGZJiEN/jrazV3NBExKF+Vte4JCzzP +0X2H24sklavn9DOLfgfKIl/vQuG355vpwG1hMwIIqAnJPk5It8vnWnNHyS/umDJFRteD8 S7Y+S8DZ/rMppdeNLyR2YPkWemHSvlM= ARC-Seal: i=1; s=default; d=yhetil.org; t=1586112126; a=rsa-sha256; cv=none; b=q4wZrqrjhAO/gmfeGAYGPRQzsBPG5svirCZjEZpU2iCK8dANhAC2WtznW08Kl3QdouxBHV ShSBapTTcEEZiE3z31lxgO2BOUM+mL5O3f8vx9siAr3ZK3xA9sNVkIB8I3Uv+3BQ1Fxii9 bW+al5AAu7atzzrA0zEY26+HkCKJD9A= ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=fail (body hash did not verify) header.d=protonmail.com header.s=default header.b=AOS0LNVo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=protonmail.com (policy=quarantine); spf=pass (aspmx2.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam: Yes Authentication-Results: aspmx2.migadu.com; dkim=fail (body hash did not verify) header.d=protonmail.com header.s=default header.b=AOS0LNVo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=protonmail.com (policy=quarantine); spf=pass (aspmx2.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Scan-Result: default: False [10.00 / 13.00]; HAS_REPLYTO(0.00)[miltonrobertvandersloot1412@protonmail.com]; R_SPF_ALLOW(-0.20)[+a]; FREEMAIL_FROM(0.00)[protonmail.com]; IP_REPUTATION_HAM(0.00)[asn: 27017(0.00), country: US(-0.01), ip: 50.126.95.6(0.00)]; ARC_SIGNED(0.00)[i=1]; R_DKIM_REJECT(1.00)[protonmail.com:s=default]; MX_GOOD(-0.50)[cached: notmuchmail.org]; DKIM_TRACE(0.00)[protonmail.com:-]; MAILLIST(-0.20)[mailman]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:27017, ipnet:50.126.64.0/18, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[miltonrobertvandersloot1412@protonmail.com,notmuch-bounces@notmuchmail.org]; ARC_NA(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; DMARC_POLICY_QUARANTINE(1.50)[protonmail.com : SPF not aligned (relaxed),quarantine]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_REPLYTO(0.00)[protonmail.com]; PREVIOUSLY_DELIVERED(0.00)[notmuch@notmuchmail.org]; HAS_LIST_UNSUB(-0.01)[]; RCPT_COUNT_ONE(0.00)[1]; TO_DN_EQ_ADDR_ALL(0.00)[]; RCVD_COUNT_SEVEN(0.00)[7]; FORGED_SENDER_MAILLIST(0.00)[] X-Scanner: scn0 X-Spam-Score: 10.00 X-TUID: 9l9Igq/V5VC8 Dear notmuch Developers test_emacs_expect_t ignores that it needs Emacs as a prerequisite. It seems (by comparing the logic of this function with the logic of other test_* functions, e.g. test_expect_success) that the test for that was introduced later and forgotten in this method. There might also be more places/other test_* methods which miss this check but I have not checked that as I'm not familiar with the codebase. Below is a patch for the test_emacs_expect_t function. Regards Milton [PATCH] Let test_emacs_expect_t respect missing external prerequisites test_emacs_expect_t did not test for missing prerequisites (even though it called test_emacs which does it). Fix that by testing for missing prerequisites. --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -548,6 +548,8 @@ test_emacs_expect_t () { inside_subtest= # Report success/failure. + test_check_missing_external_prereqs_ "$test_subtest_name" || + { result=$(cat OUTPUT) if [ "$result" = t ] then @@ -555,6 +557,7 @@ test_emacs_expect_t () { else test_failure_ "${result}" fi + } else # Restore state after the (non) test. exec 1>&6 2>&7 # Restore stdout and stderr