From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Jameson Rollins <jrollins@finestructure.net>
Cc: notmuch@notmuchmail.org
Subject: Re: `notmuch setup` replaces `~/.notmuch-config` instead of truncating it
Date: Tue, 16 Nov 2010 10:38:20 -0500 [thread overview]
Message-ID: <4CE2A56C.4080407@fifthhorseman.net> (raw)
In-Reply-To: <87k4kdbd77.fsf@servo.finestructure.net>
[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]
On 11/16/2010 08:38 AM, Jameson Rollins wrote:
> On Tue, 16 Nov 2010 15:33:30 +0200, "Ciprian Dorin, Craciun" <ciprian.craciun@gmail.com> wrote:
>> So my question is: is this behaviour (of deleting the file and
>> creating a new one) deliberate? If not, could it be fixed (I could
>> provide a patch) to just update the file in place?
>
> Hi, Ciprian. I had not noticed this, but now that you mention it, I see
> that the same thing happened to me. This behavior is surely not
> deliberate, and is definitely undesirable. A patch would be welcome.
It often is desirable to do a replacement instead of truncation or
appending -- atomic replacement guarantees that a legitimate copy is
always available. It eliminates a window of time when the config file
would be in an intermediate state. Readers of the file always get
either the old state or the new state -- nothing in between.
However, you can address both concerns by detecting whether
~/.notmuch-config is a symlink and readlink()ing until you get to the
underlying file. Then atomically replace the target instead of the
symlink itself.
--dkg
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]
next prev parent reply other threads:[~2010-11-16 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 13:33 `notmuch setup` replaces `~/.notmuch-config` instead of truncating it Ciprian Dorin, Craciun
2010-11-16 13:38 ` Jameson Rollins
2010-11-16 15:38 ` Daniel Kahn Gillmor [this message]
2010-11-16 19:09 ` Carl Worth
2010-11-16 20:26 ` Ciprian Dorin, Craciun
2010-11-16 20:37 ` Daniel Kahn Gillmor
2010-11-16 20:42 ` Daniel Kahn Gillmor
2010-11-16 22:17 ` Ciprian Dorin, Craciun
2010-11-16 22:16 ` Ciprian Dorin, Craciun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE2A56C.4080407@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).