From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 779F74196F2 for ; Mon, 12 Apr 2010 19:05:09 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cErLJba4ALYV for ; Mon, 12 Apr 2010 19:05:07 -0700 (PDT) Received: from office.neopsis.com (office.neopsis.com [78.46.209.98]) by olra.theworths.org (Postfix) with ESMTP id 36D00431FC1 for ; Mon, 12 Apr 2010 19:05:07 -0700 (PDT) Received: from calvin.caurea.org ([62.65.141.13]) (authenticated user tom@dbservice.com) by office.neopsis.com (using TLSv1/SSLv3 with cipher AES256-SHA (256 bits)); Tue, 13 Apr 2010 04:04:40 +0200 Message-ID: <4BC3D137.6010801@dbservice.com> Date: Tue, 13 Apr 2010 04:04:39 +0200 From: Tomas Carnecky User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: Mikhail Gusarov Subject: Re: Use of strcasestr References: <4BC326F2.10300@dbservice.com> <87zl182znk.fsf@leibnitz.dottedmag.net> In-Reply-To: <87zl182znk.fsf@leibnitz.dottedmag.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: notmuch X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2010 02:05:09 -0000 On 4/12/10 10:18 PM, Mikhail Gusarov wrote: > > Twas brillig at 15:58:10 12.04.2010 UTC+02 when tom@dbservice.com did gyre and gimble: > > TC> In 4fd9ea0 (guess From address from Received headers, 2010-04-06) you introduced > TC> strcasestr, which is not portable, see 82e47ec (notmuch reply: Use strstr > TC> instead of strcasestr for portability., 2010-02-04). > > TC> Is strcasestr really necessary there or can it be replaced with strstr? > > strcasecmp is POSIX.1-2001. Indeed it is, but the code uses strcasestr and I couldn't find any indication which standard that function is part of. Adding that function to compat/ probably is the way to go, but the whole compat mechanism doesn't work here. It's like if compat/Makefile.local was not included in the top-level makefile, notmuch_compat_srcs is empty there. Any ideas how to debug that? tom