From: Tomas Carnecky <tom@dbservice.com>
To: Mikhail Gusarov <dottedmag@dottedmag.net>
Cc: notmuch <notmuch@notmuchmail.org>
Subject: Re: Use of strcasestr
Date: Tue, 13 Apr 2010 04:04:39 +0200 [thread overview]
Message-ID: <4BC3D137.6010801@dbservice.com> (raw)
In-Reply-To: <87zl182znk.fsf@leibnitz.dottedmag.net>
On 4/12/10 10:18 PM, Mikhail Gusarov wrote:
>
> Twas brillig at 15:58:10 12.04.2010 UTC+02 when tom@dbservice.com did gyre and gimble:
>
> TC> In 4fd9ea0 (guess From address from Received headers, 2010-04-06) you introduced
> TC> strcasestr, which is not portable, see 82e47ec (notmuch reply: Use strstr
> TC> instead of strcasestr for portability., 2010-02-04).
>
> TC> Is strcasestr really necessary there or can it be replaced with strstr?
>
> strcasecmp is POSIX.1-2001.
Indeed it is, but the code uses strcasestr and I couldn't find any
indication which standard that function is part of.
Adding that function to compat/ probably is the way to go, but the whole
compat mechanism doesn't work here. It's like if compat/Makefile.local
was not included in the top-level makefile, notmuch_compat_srcs is empty
there. Any ideas how to debug that?
tom
next prev parent reply other threads:[~2010-04-13 2:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 13:58 Use of strcasestr Tomas Carnecky
2010-04-12 15:53 ` Dirk Hohndel
2010-04-12 20:18 ` Mikhail Gusarov
2010-04-13 2:04 ` Tomas Carnecky [this message]
2010-04-13 2:42 ` Aaron Ecay
2010-04-13 4:09 ` Dirk Hohndel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC3D137.6010801@dbservice.com \
--to=tom@dbservice.com \
--cc=dottedmag@dottedmag.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).