From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id CBD36431FC1 for ; Wed, 14 Apr 2010 12:23:35 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.6 X-Spam-Level: X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7] autolearn=unavailable Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LXUbSOY0YA5e for ; Wed, 14 Apr 2010 12:23:35 -0700 (PDT) Received: from VA3EHSOBE006.bigfish.com (va3ehsobe005.messaging.microsoft.com [216.32.180.15]) by olra.theworths.org (Postfix) with ESMTP id A74334196F2 for ; Wed, 14 Apr 2010 12:23:34 -0700 (PDT) Received: from mail98-va3-R.bigfish.com (10.7.14.254) by VA3EHSOBE006.bigfish.com (10.7.40.26) with Microsoft SMTP Server id 8.1.240.5; Wed, 14 Apr 2010 19:23:34 +0000 Received: from mail98-va3 (localhost.localdomain [127.0.0.1]) by mail98-va3-R.bigfish.com (Postfix) with ESMTP id 10C00B487D9; Wed, 14 Apr 2010 19:23:34 +0000 (UTC) X-SpamScore: -4 X-BigFish: VPS-4(zz98dNzz1202hz31izz32i2a8h43h61h) X-Spam-TCS-SCL: 0:0 Received: from mail98-va3 (localhost.localdomain [127.0.0.1]) by mail98-va3 (MessageSwitch) id 1271273012425203_29041; Wed, 14 Apr 2010 19:23:32 +0000 (UTC) Received: from VA3EHSMHS001.bigfish.com (unknown [10.7.14.239]) by mail98-va3.bigfish.com (Postfix) with ESMTP id 61A6113B8051; Wed, 14 Apr 2010 19:23:32 +0000 (UTC) Received: from ausb3extmailp01.amd.com (163.181.251.8) by VA3EHSMHS001.bigfish.com (10.7.99.11) with Microsoft SMTP Server (TLS) id 14.0.482.44; Wed, 14 Apr 2010 19:23:31 +0000 Received: from ausb3twp01.amd.com ([163.181.250.37]) by ausb3extmailp01.amd.com (Switch-3.2.7/Switch-3.2.7) with SMTP id o3EJJBjh017603; Wed, 14 Apr 2010 14:19:14 -0500 X-WSS-ID: 0L0VSIZ-01-3GK-02 X-M-MSG: Received: from sausexhtp01.amd.com (sausexhtp01.amd.com [163.181.3.165]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by ausb3twp01.amd.com (Tumbleweed MailGate 3.7.2) with ESMTP id 2B0271028889; Wed, 14 Apr 2010 14:23:23 -0500 (CDT) Received: from optimon.amd.com (163.181.34.104) by sausexhtp01.amd.com (163.181.3.165) with Microsoft SMTP Server (TLS) id 8.2.234.1; Wed, 14 Apr 2010 12:23:27 -0700 Received: from mhdc-ns01.amd.com (mhdc-ns01.amd.com [165.204.35.147]) by optimon.amd.com (8.12.10/8.12.10) with ESMTP id o3EJNQjv009999; Wed, 14 Apr 2010 14:23:27 -0500 Received: from testarossa.amd.com (testarossa.amd.com [165.204.147.44]) by mhdc-ns01.amd.com (8.13.8+Sun/8.13.8) with ESMTP id o3EJNBTR000750; Wed, 14 Apr 2010 13:23:11 -0600 (MDT) Received: (from manderso@localhost) by testarossa.amd.com (8.13.1/8.13.1/Submit) id o3EJNBVI027185; Wed, 14 Apr 2010 13:23:11 -0600 X-Authentication-Warning: testarossa.amd.com: manderso set sender to MarkR.Anderson@amd.com using -f From: Mark Anderson To: Jesse Rosenthal , Carl Worth , "notmuch\@notmuchmail.org" Subject: Re: [PATCH] Fix bug, and clean up code duplication, in adding or removing tag by region. In-Reply-To: References: <87sk90ragj.fsf@jhu.edu> <87aatfq88h.fsf@yoom.home.cworth.org> <877hogaf7v.fsf@jhu.edu> <878w8rkzis.fsf@yoom.home.cworth.org> <871vejxk94.fsf@jhu.edu> <87zl16ez21.fsf@yoom.home.cworth.org> Date: Wed, 14 Apr 2010 13:23:11 -0600 Message-ID: <3wdtyrd2600.fsf@testarossa.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-Virus-Scanned: ClamAV version 0.87.1, clamav-milter version 0.87 on optimon.amd.com X-Virus-Status: Clean X-Reverse-DNS: unknown X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2010 19:23:36 -0000 On Wed, 14 Apr 2010 12:50:50 -0500, Jesse Rosenthal wrote: > It occurs to me that the best way to do this would probably be to go to > point-max, and then (forward-line -1) until we hit a thread-id. That way > we wouldn't have to work all the way down long search indexes. I'll try > to code that up for the next release, and then have > notmuch-search-last-thread use it, as well as the region functions. This sounds great, just be careful if this command is run before the buffer has completed loading, as you could be in the middle of a search instead of the end. AFAIK, with the "asynchronous" buffer loading, there's no guarantee that point-max is the end of the search until the other thread has exited. Again, my lisp-fu is very poor, but just a concern I see. -Mark