From: Mark Anderson <MarkR.Anderson@amd.com>
To: Jesse Rosenthal <jrosenthal@jhu.edu>,
Carl Worth <cworth@cworth.org>,
"notmuch\@notmuchmail.org" <notmuch@notmuchmail.org>
Subject: Re: [PATCH] Fix bug, and clean up code duplication, in adding or removing tag by region.
Date: Wed, 14 Apr 2010 13:23:11 -0600 [thread overview]
Message-ID: <3wdtyrd2600.fsf@testarossa.amd.com> (raw)
In-Reply-To: <m1bpdlord1.fsf@watt.gilman.jhu.edu>
On Wed, 14 Apr 2010 12:50:50 -0500, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:
> It occurs to me that the best way to do this would probably be to go to
> point-max, and then (forward-line -1) until we hit a thread-id. That way
> we wouldn't have to work all the way down long search indexes. I'll try
> to code that up for the next release, and then have
> notmuch-search-last-thread use it, as well as the region functions.
This sounds great, just be careful if this command is run before the
buffer has completed loading, as you could be in the middle of a search
instead of the end.
AFAIK, with the "asynchronous" buffer loading, there's no guarantee that
point-max is the end of the search until the other thread has exited.
Again, my lisp-fu is very poor, but just a concern I see.
-Mark
prev parent reply other threads:[~2010-04-14 19:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 20:58 [PATCH] notmuch.el: add functionality to add or remove tags by region Jesse Rosenthal
2010-01-21 11:27 ` Jesse Rosenthal
2010-01-21 15:23 ` Jameson Rollins
2010-01-21 15:35 ` Jesse Rosenthal
2010-01-21 15:56 ` Jameson Rollins
2010-01-21 16:07 ` Jesse Rosenthal
2010-01-21 16:10 ` Jesse Rosenthal
2010-02-17 0:07 ` [PATCH v2] notmuch.el: add functionality in notmuch search mode " Jesse Rosenthal
2010-02-17 12:12 ` [PATCH] notmuch.el: bind 'd' to new function notmuch-search-delete-thread-or-region Sebastian Spaeth
2011-07-15 4:11 ` anarcat
2011-07-19 19:48 ` Matthieu Lemerre
2011-07-16 18:39 ` [PATCH 1/2] add notmuch keybinding 'd' Antoine Beaupré
2012-01-03 14:56 ` David Edmondson
2012-01-03 19:57 ` Jani Nikula
2012-01-03 21:35 ` Jameson Graef Rollins
2012-01-04 8:27 ` Jani Nikula
2012-01-06 20:10 ` Antoine Beaupré
2012-01-06 20:20 ` Jameson Graef Rollins
2012-01-06 20:51 ` David Bremner
2012-01-17 5:02 ` Antoine Beaupré
2012-01-06 21:33 ` Jani Nikula
2012-01-06 21:40 ` Tomi Ollila
2012-01-04 8:52 ` David Edmondson
2012-01-17 5:03 ` Antoine Beaupré
2010-04-07 21:10 ` [PATCH v2] notmuch.el: add functionality in notmuch search mode to add or remove tags by region Carl Worth
2010-04-09 14:11 ` Jesse Rosenthal
2010-04-13 17:55 ` Carl Worth
2010-04-13 18:00 ` Jesse Rosenthal
2010-04-13 18:47 ` [PATCH] Fix bug, and clean up code duplication, in adding or removing tag " Jesse Rosenthal
2010-04-14 17:14 ` Carl Worth
2010-04-14 17:50 ` Jesse Rosenthal
2010-04-14 19:23 ` Mark Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3wdtyrd2600.fsf@testarossa.amd.com \
--to=markr.anderson@amd.com \
--cc=cworth@cworth.org \
--cc=jrosenthal@jhu.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).