os x getline issues

os x getline issues

[Bhaskara Marthi]

[-- Attachment #1: Type: text/plain, Size: 1706 bytes --]

Hi all, I'm trying to build notmuch on os x (master branch from today).  I
got the ports for gmime and xapian, and installed talloc from source, with
some minor hitches (just getting talloc alone from samba failed on autoconf
due to lack of libreplace.m4, so I installed all of samba from a port; a
pkg-config file for talloc was not put in the right place after that,
though, so I had to make one).

Anyway, now compilation runs into the following error.  Looks like an issue
with the makefile given that getline is in fact defined in compat/.  How
should I fix this?
- Bhaskara

g++ debugger.o gmime-filter-reply.o notmuch.o notmuch-config.o
notmuch-count.o notmuch-dump.o notmuch-new.o notmuch-reply.o
notmuch-restore.o notmuch-search.o notmuch-search-tags.o notmuch-setup.o
notmuch-show.o notmuch-tag.o notmuch-time.o query-string.o show-message.o
json.o lib/notmuch.a  -L/opt/local/lib -lgmime-2.4 -lz -lgobject-2.0
-lglib-2.0 -lintl -liconv   -L/opt/local/lib/samba3 -ltalloc
-L/opt/local/lib -lxapian -lz -L/opt/local/lib -o notmuch
Undefined symbols:
  "_getline", referenced from:
      _notmuch_restore_command in notmuch-restore.o
      _notmuch_restore_command in notmuch-restore.o
      _notmuch_setup_command in notmuch-setup.o
      _notmuch_setup_command in notmuch-setup.o
      _notmuch_setup_command in notmuch-setup.o
      _notmuch_setup_command in notmuch-setup.o
      _notmuch_setup_command in notmuch-setup.o
      _notmuch_message_file_get_header in notmuch.a(message-file.o)
      _notmuch_message_file_get_header in notmuch.a(message-file.o)
      _notmuch_message_file_get_header in notmuch.a(message-file.o)
      _notmuch_message_file_get_header in notmuch.a(message-file.o)

[-- Attachment #2: Type: text/html, Size: 1795 bytes --]

[PATCH] Fix compilation when getline is not available

[Michal Sojka]

On Mon, 29 Mar 2010, Bhaskara Marthi wrote:
> Hi all, I'm trying to build notmuch on os x (master branch from today).  I
> got the ports for gmime and xapian, and installed talloc from source, with
> some minor hitches (just getting talloc alone from samba failed on autoconf
> due to lack of libreplace.m4, so I installed all of samba from a port; a
> pkg-config file for talloc was not put in the right place after that,
> though, so I had to make one).
> 
> Anyway, now compilation runs into the following error.  Looks like an issue
> with the makefile given that getline is in fact defined in compat/.  How
> should I fix this?

The following patch should fix it.
---
 Makefile              |    2 +-
 compat/Makefile.local |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 46f001c..93c6b2b 100644
--- a/Makefile
+++ b/Makefile
@@ -46,7 +46,7 @@ subdirs = compat emacs lib
 global_deps = Makefile Makefile.config Makefile.local \
 	$(subdirs:%=%/Makefile) $(subdirs:%=%/Makefile.local)
 
-include Makefile.config Makefile.local $(subdirs:%=%/Makefile.local)
+include Makefile.config $(subdirs:%=%/Makefile.local) Makefile.local
 
 # The user has not set any verbosity, default to quiet mode and inform the
 # user how to enable verbose compiles.
diff --git a/compat/Makefile.local b/compat/Makefile.local
index 17b4514..9f84c5f 100644
--- a/compat/Makefile.local
+++ b/compat/Makefile.local
@@ -1,7 +1,7 @@
 dir := compat
 extra_cflags += -I$(dir)
 
-notmuch_compat_srcs =
+notmuch_compat_srcs :=
 
 ifneq ($(HAVE_GETLINE),1)
 notmuch_compat_srcs += $(dir)/getline.c $(dir)/getdelim.c
-- 
1.7.0.2

Re: [PATCH] Fix compilation when getline is not available

[Bhaskara Marthi]

[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]

On Mon, Mar 29, 2010 at 1:43 AM, Michal Sojka <sojkam1@fel.cvut.cz> wrote:

> On Mon, 29 Mar 2010, Bhaskara Marthi wrote:
> > Hi all, I'm trying to build notmuch on os x (master branch from today).
>  I
> > got the ports for gmime and xapian, and installed talloc from source,
> with
> > some minor hitches (just getting talloc alone from samba failed on
> autoconf
> > due to lack of libreplace.m4, so I installed all of samba from a port; a
> > pkg-config file for talloc was not put in the right place after that,
> > though, so I had to make one).
> >
> > Anyway, now compilation runs into the following error.  Looks like an
> issue
> > with the makefile given that getline is in fact defined in compat/.  How
> > should I fix this?
>
> The following patch should fix it.
>

Works for me.  Thanks!
- Bhaskara



> ---
>  Makefile              |    2 +-
>  compat/Makefile.local |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 46f001c..93c6b2b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -46,7 +46,7 @@ subdirs = compat emacs lib
>  global_deps = Makefile Makefile.config Makefile.local \
>        $(subdirs:%=%/Makefile) $(subdirs:%=%/Makefile.local)
>
> -include Makefile.config Makefile.local $(subdirs:%=%/Makefile.local)
> +include Makefile.config $(subdirs:%=%/Makefile.local) Makefile.local
>
>  # The user has not set any verbosity, default to quiet mode and inform the
>  # user how to enable verbose compiles.
> diff --git a/compat/Makefile.local b/compat/Makefile.local
> index 17b4514..9f84c5f 100644
> --- a/compat/Makefile.local
> +++ b/compat/Makefile.local
> @@ -1,7 +1,7 @@
>  dir := compat
>  extra_cflags += -I$(dir)
>
> -notmuch_compat_srcs =
> +notmuch_compat_srcs :=
>
>  ifneq ($(HAVE_GETLINE),1)
>  notmuch_compat_srcs += $(dir)/getline.c $(dir)/getdelim.c
> --
> 1.7.0.2
>

[-- Attachment #2: Type: text/html, Size: 2486 bytes --]