unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org
Subject: [PATCH 7/9] build: do not touch roff files after sphinx-build
Date: Sat,  5 Nov 2016 22:18:16 +0200	[thread overview]
Message-ID: <2bf3de99793f6de7488f60dcc5482f08bc92d0f4.1478376896.git.jani@nikula.org> (raw)
In-Reply-To: <cover.1478376896.git.jani@nikula.org>
In-Reply-To: <cover.1478376896.git.jani@nikula.org>

If Sphinx fails to create any of the roff files, having touch create
them hides the errors until someone realizes, possibly much later,
that the resulting files are empty. (Note that gzip doesn't fail on
empty input files.) Sphinx will change the timestamps of any files it
has written anyway.
---
 doc/Makefile.local | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/Makefile.local b/doc/Makefile.local
index 8633cfcd3b51..5dc1cad489cc 100644
--- a/doc/Makefile.local
+++ b/doc/Makefile.local
@@ -53,7 +53,7 @@ else
 	@echo "Fatal: build dependency fail."
 	@false
 endif
-	touch ${MAN_ROFF_FILES} $@
+	touch $@
 
 install-man: install-apidocs
 
-- 
2.1.4

  parent reply	other threads:[~2016-11-05 20:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-05 20:18 [PATCH 0/9] doc: config and build improvements Jani Nikula
2016-11-05 20:18 ` [PATCH 1/9] doc/conf.py: add notmuch-emacs-mua to texinfo documents Jani Nikula
2016-11-05 20:18 ` [PATCH 2/9] doc/conf.py: generate texinfo_documents list from man_pages list Jani Nikula
2016-11-05 20:18 ` [PATCH 3/9] doc/conf.py: abstract notmuch authors Jani Nikula
2016-11-05 20:18 ` [PATCH 4/9] doc/conf.py: reindent, whitespace clean man page, texinfo lists Jani Nikula
2016-11-05 20:18 ` [PATCH 5/9] doc/conf.py: include command name in texinfo document title Jani Nikula
2016-11-05 20:18 ` [PATCH 6/9] doc: fix references in notmuch-emacs.rst Jani Nikula
2016-11-05 20:18 ` Jani Nikula [this message]
2016-11-05 20:18 ` [PATCH 8/9] build: generate man page list from source files, not conf.py Jani Nikula
2016-11-05 20:18 ` [PATCH 9/9] build: only install known man pages Jani Nikula
2016-11-16 17:36 ` [PATCH 0/9] doc: config and build improvements Tomi Ollila
2016-11-18  2:19 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bf3de99793f6de7488f60dcc5482f08bc92d0f4.1478376896.git.jani@nikula.org \
    --to=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).